Fix #537 - handle missing and empty Element column in PDB files #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| element = Element.valueOfIgnoreCase(line.substring (76, 78).trim()); | ||
| } catch (IllegalArgumentException e){} | ||
| String elementSymbol = line.substring(76, 78).trim(); | ||
| if (elementSymbol.equals("")) { |
There was a problem hiding this comment.
Minor comment: better use isEmpty() here
|
Nice stuff! I think we could try to cherry pick this one into the bugfix branch. I think it shouldn't conflict too much despite the parser was changed a lot in 5.0. I'd say let's try cherry picking and if it isn't easy to merge then we can drop it. |
|
I made the changes |
|
Thanks! |
|
Alright I've tried cherry picking back to bugfixes-4.2 but it was complicated. Let's just keep this for the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element information is filled using the Chemical Component Dictionary information, as discussed in #537.