Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local Highcharts and update license #32

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

kernc
Copy link
Contributor

@kernc kernc commented Mar 21, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #32 into master will decrease coverage by 2.4%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   97.98%   95.57%   -2.41%     
==========================================
  Files          13       15       +2     
  Lines        1635     1739     +104     
  Branches      189      209      +20     
==========================================
+ Hits         1602     1662      +60     
- Misses         21       54      +33     
- Partials       12       23      +11
Impacted Files Coverage Δ
...gecontrib/educational/widgets/owgradientdescent.py 98.72% <100%> (ø) ⬆️
...contrib/educational/widgets/highcharts/__init__.py 100% <100%> (ø)
orangecontrib/educational/widgets/owkmeans.py 95.4% <100%> (+0.01%) ⬆️
.../educational/widgets/owpolynomialclassification.py 98.22% <100%> (ø) ⬆️
...ntrib/educational/widgets/highcharts/highcharts.py 56.43% <56.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4161df9...1b7473b. Read the comment docs.

@astaric
Copy link
Member

astaric commented Mar 23, 2017

I have removed the highcharts code from the local orange installation and the educational widget continue to work. I guess this is good to go.

@astaric astaric merged commit fcde40d into biolab:master Mar 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants