Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Load data: Add data loader for H5AD format #356

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

pavlin-policar
Copy link
Collaborator

Issue

The load data widget does not support the h5ad format. This format is by far the nicest and fastest format I've used for sparse gene expression matrices. scanpy and seurat both support this format.

Description of changes

Add an H5AD reader.

Includes
  • Code changes
  • Tests
  • Documentation

@JakaKokosar
Copy link
Member

JakaKokosar commented Sep 3, 2019

Hm.. anndata is not available trough conda-forge channel (it is on bioconda channel). This means we will brake recipe build for the next release.

Support for multiple channels in recipes is not supported: conda/conda-build#3656

Maybe we should just throw a warning if anndata can not be imported.

@pavlin-policar
Copy link
Collaborator Author

Is it possible to specify additional conda channels when building the package? anndata is available on conda through bioconda (taken from their readme: conda install anndata -c bioconda). I don't actually think this is possible, unforuntately.

It seems to me that this is constantly popping up. Isn't there some way to manually install the package through pip using build.sh?

@JakaKokosar
Copy link
Member

conda-forge/staged-recipes#9398

I have added you to be a maintainer, please confirm in PR.

@JakaKokosar
Copy link
Member

This looks good to me! Also, the recipe tests pass and will hopefully be merged soon.

@VesnaT Can you maybe quickly look at it and merge if OK?

@pavlin-policar
Copy link
Collaborator Author

pavlin-policar commented Sep 3, 2019 via email

@JakaKokosar
Copy link
Member

What is wrong with the current license?

@pavlin-policar
Copy link
Collaborator Author

Never mind, I checked the license and it's got the BSD-3 clause, which should be fine.

A year or so ago there was a discussion in the lab about licensing and we had to be careful about which packages were added to dependencies because of this. I don't really know if that lead anywhere, but it's better to check this before adding a potentially non-commercially licensed software package to dependencies. But like I said, this one has BSD-3, which should be fine.

@VesnaT VesnaT merged commit 09ad99f into biolab:master Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants