Mosaic Vizrank: Start when opened, pause when closed #6633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Ref. #6504. I also strongly suspect
Based on #6614 (for
auto_startflag, and forCloseVizrankMixin). Only the last commit is new.@processo was totally right in #6504. I knew that closing VizRank doesn't stop it, but I expected that closing the widget would. Of course it doesn't, and in case of Mosaic, which rapidly fills the table model and fires signals, it blocks the main thread, making Orange basically unresponsive even after the widget is closed and everything should have been silent.
When #6612 or alike is merged, we should prevent vizranks from sending such frequent updates.
Description of changes
Changes are similar to those made to vizranks in #6614.
Includes