VizRank: Reimplementation #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
vizrank-2.0
branch
2 times, most recently
from
e8f13f7
to
bfa96db
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6661 +/- ##
==========================================
- Coverage 88.10% 88.09% -0.02%
==========================================
Files 321 322 +1
Lines 69950 70096 +146
==========================================
+ Hits 61631 61751 +120
- Misses 8319 8345 +26 |
janezd
force-pushed
the
vizrank-2.0
branch
3 times, most recently
from
ca3ed0a
to
21c641c
Compare
2 tasks
|
Mosaic
Sieve
Linear Projection
Radviz
Scatter Plot
|
janezd
force-pushed
the
vizrank-2.0
branch
3 times, most recently
from
1a16af0
to
01f7ef7
Compare
|
I now change the code so that
This is in a separate commit and not explicitly tested. Perhaps I may be persuaded to add some tests, though they'd be rather stupid. |
VesnaT
reviewed
Dec 14, 2023
| def initialize(self): | ||
| super().initialize() | ||
| self.attrs = self.master.attrs | ||
| caption_title = "Sieve Rank" |
There was a problem hiding this comment.
This is never used. You probably ment captionTitle.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #6504. Also fixes #6624.
#6614 would fixed the above problems, but poking the VizRank code that didn't age well introduced new bugs, and testing exposed some existing bugs.
This PR implements a new, cleaner and leaner VizRank.
Includes