Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for issues 348 #349

Merged
merged 1 commit into from Oct 27, 2021
Merged

Patch for issues 348 #349

merged 1 commit into from Oct 27, 2021

Conversation

RichardBruskiewich
Copy link
Collaborator

@RichardBruskiewich RichardBruskiewich commented Oct 26, 2021

…rsion (this eliminates the designated_type error, but still has some other unit test failures)
@RichardBruskiewich
Copy link
Collaborator Author

RichardBruskiewich commented Oct 27, 2021

Hi @deepakunni3 ,

Unit tests are failing on the RDF and OWL code. The strange thing is that they fail both before and after the flipping of a relational operator which seems a bit odd as it relates to the edge cache of the rdf_source.py (see https://github.com/biolink/kgx/blob/master/kgx/source/rdf_source.py#L276). Can you take a closer look?

I also wonder about the dereify (https://github.com/biolink/kgx/blob/master/kgx/source/rdf_source.py#L332) method which ignores OBAN node properties like http://purl.org/oban/association_has_subject, http://purl.org/oban/association_has_predicate and http://purl.org/oban/association_has_object, which are used in the OBAN NT file (how universal are those properties in RDF inputs?) @balhoff maybe you have an opinion about this?

I need to spend time on some other KGX issues, so I can put this issue on the back burner pending your inputs?

@RichardBruskiewich
Copy link
Collaborator Author

Splitting out the RDF/OWL concerns to PR #351

@RichardBruskiewich RichardBruskiewich marked this pull request as ready for review October 27, 2021 14:50
@RichardBruskiewich RichardBruskiewich merged commit 9f9c0fa into master Oct 27, 2021
@RichardBruskiewich RichardBruskiewich deleted the issue-348-patch branch October 27, 2021 14:50
@RichardBruskiewich RichardBruskiewich changed the title Patch for issues 348 and 350 Patch for issues 348 Oct 27, 2021
@deepakunni3
Copy link
Member

Not sure what is going on here. I'll take a look at the linked tickets and PR.

@deepakunni3
Copy link
Member

@RichardBruskiewich Incrementing linkml fixed the tests?

@RichardBruskiewich
Copy link
Collaborator Author

@RichardBruskiewich Incrementing linkml fixed the tests?

Hi @deepakunni3, only the original "designates_type" error was fixed. The other RDF and OWL test failures continued. See PR #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: Unknown argument: designates_type = True error in 'make tests'
2 participants