Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT: new brightness values not published #119

Closed
GeneralLuzi opened this issue Nov 21, 2021 · 11 comments
Closed

MQTT: new brightness values not published #119

GeneralLuzi opened this issue Nov 21, 2021 · 11 comments

Comments

@GeneralLuzi
Copy link

Hi,

while setting a new value for the loudness is working fine, brightness does not work properly IMHO.

Use Case for loudness:

  1. ESPUINO_MQTT publishes on start e.g. 10.
  2. PRIVATE_MQTT_CLIENT receives 10
  3. PRIVATE_MQTT_CLIENT publishes 11
  4. ESPUINO_MQTT receives 11 and espuino sets loudness to 11
  5. ESPUINO_MQTT publishes 11
  6. PRIVATE_MQTT_CLIENT receives 11

Use Case for brightness:

  1. ESPUINO_MQTT publishes on start e.g. 10.
  2. PRIVATE_MQTT_CLIENT receives 10
  3. PRIVATE_MQTT_CLIENT publishes 11
  4. ESPUINO_MQTT receives 11 and espuino sets brightness to 11
    -- NOT WORKING BELOW THIS LINE --
  5. ESPUINO_MQTT publishes 11
  6. PRIVATE_MQTT_CLIENT receives 11

Thanks and regards,
GL

@GeneralLuzi GeneralLuzi changed the title MQTT: new values not published MQTT: new brightnessvalues not published Nov 21, 2021
@GeneralLuzi GeneralLuzi changed the title MQTT: new brightnessvalues not published MQTT: new brightness values not published Nov 21, 2021
@GeneralLuzi
Copy link
Author

Same on:

  • topicLockControlsCmnd
  • Cmnd/ESPuino/SleepTimer

@biologist79
Copy link
Owner

Need to investigate.

thebino added a commit to thebino/ESPuino that referenced this issue Nov 22, 2021
thebino added a commit to thebino/ESPuino that referenced this issue Nov 22, 2021
thebino added a commit to thebino/ESPuino that referenced this issue Nov 22, 2021
@thebino
Copy link
Contributor

thebino commented Nov 22, 2021

I discovered the same issue today. Fix can be found here: #124

@GeneralLuzi
Copy link
Author

GeneralLuzi commented Nov 22, 2021 via email

@thebino
Copy link
Contributor

thebino commented Nov 22, 2021

@GeneralLuzi You can just checkout the branch and deploy it to your device. It will be reviewed this week anyway :D

@GeneralLuzi
Copy link
Author

@thebino my test shows 2 out of 3. Well done! 👍

Brightness and SleepTimer I can confirm to be fixed. Somehow LockControls is not publishing the change! Could you have a look please?

Thanks!

thebino added a commit to thebino/ESPuino that referenced this issue Nov 22, 2021
@thebino
Copy link
Contributor

thebino commented Nov 22, 2021

@GeneralLuzi can you pull the latest state and validate if it updates the state now? Haven't tested myself. Just added the fix and pushed it.

@biologist79
Copy link
Owner

Merged into master.
@GeneralLuzi Please review if it's working for you.

@GeneralLuzi
Copy link
Author

Thanks @biologist79

I retested the feature on the branch of @thebino this morning and it worked. Afterwards I wanted to test the RFID commands in combination with MQTT and discovered a major fail - my SD Card (filesystem?!) was destroyed... Not sure why and how... I am trying to recap... maybe a new issue - maybe just bad luck with the SD card not sure

After fixing the SD Card, I will test the merge and comment again...

@biologist79
Copy link
Owner

Can this one be closed?

@GeneralLuzi
Copy link
Author

I will close this issue. Thanks for fixing. If there is anything left, I will re-open again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants