Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(js_semantic): separate binding and scope nodes #3387

Merged
merged 5 commits into from
Jul 8, 2024

Conversation

Conaclos
Copy link
Member

@Conaclos Conaclos commented Jul 8, 2024

Summary

This PR introduces minor changes for the semantic model.
It separates binding and scope nodes to make easier refactoring around the way we identify a scope and a binding.
I also change all usize to u32.

Test Plan

CI must pass

@github-actions github-actions bot added the L-JavaScript Language: JavaScript and super languages label Jul 8, 2024
@Conaclos Conaclos changed the title Conaclos/semantic model refactor(js_semantic): separate binding and scope nodes Jul 8, 2024
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Parser conformance results on

js/262

Test result main count This PR count Difference
Total 48223 48223 0
Passed 47026 47026 0
Failed 1197 1197 0
Panics 0 0 0
Coverage 97.52% 97.52% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 40 40 0
Passed 37 37 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.50% 92.50% 0.00%

symbols/microsoft

Test result main count This PR count Difference
Total 6538 6538 0
Passed 2198 2198 0
Failed 4340 4340 0
Panics 0 0 0
Coverage 33.62% 33.62% 0.00%

ts/babel

Test result main count This PR count Difference
Total 669 669 0
Passed 597 597 0
Failed 72 72 0
Panics 0 0 0
Coverage 89.24% 89.24% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 18250 18250 0
Passed 13987 13987 0
Failed 4263 4263 0
Panics 0 0 0
Coverage 76.64% 76.64% 0.00%

@Conaclos Conaclos merged commit d9ed6d1 into main Jul 8, 2024
14 of 15 checks passed
@Conaclos Conaclos deleted the conaclos/semantic-model branch July 8, 2024 16:12
@Conaclos Conaclos added the A-Changelog Area: changelog label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant