-
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(biome_js_analyzer): implement useConsistentMemberAccessibility
#3536
feat(biome_js_analyzer): implement useConsistentMemberAccessibility
#3536
Conversation
CodSpeed Performance ReportMerging #3536 will not alter performanceComparing Summary
|
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! This looks already good! I left some comments and suggestions :)
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
crates/biome_js_analyze/src/lint/nursery/use_consistent_member_accessibility.rs
Outdated
Show resolved
Hide resolved
0ec7956
to
eccbf81
Compare
0a6f1b3
to
9fbc308
Compare
@Conaclos |
9fbc308
to
4c03603
Compare
@Conaclos |
Summary
close #3271
implement useConsistentMemberAccessibility
Test Plan
Add snaps for valid/invalid cases