Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(biome_js_analyzer): implement useConsistentMemberAccessibility #3536

Merged

Conversation

seitarof
Copy link
Contributor

Summary

close #3271
implement useConsistentMemberAccessibility

Test Plan

Add snaps for valid/invalid cases

@github-actions github-actions bot added A-CLI Area: CLI A-Project Area: project A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis A-Changelog Area: changelog labels Jul 28, 2024
Copy link

codspeed-hq bot commented Jul 28, 2024

CodSpeed Performance Report

Merging #3536 will not alter performance

Comparing seitarof:feat/use-consistent-member-accessibility (4c03603) with main (33040d7)

Summary

✅ 99 untouched benchmarks

Copy link
Member

@Conaclos Conaclos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This looks already good! I left some comments and suggestions :)

@Conaclos Conaclos force-pushed the feat/use-consistent-member-accessibility branch from 0ec7956 to eccbf81 Compare August 29, 2024 17:08
@Conaclos
Copy link
Member

Conaclos commented Aug 29, 2024

@dyc3 @chansuke I updated the PR. I integrated the last reviews and I rebased on main (I squashed the commits to simplify the rebasing). Take a quick look and if everything is good we can merge :)

Note: I think we can leave the code fix for a future PR.

@Conaclos Conaclos force-pushed the feat/use-consistent-member-accessibility branch from 0a6f1b3 to 9fbc308 Compare August 29, 2024 18:02
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@chansuke
Copy link
Member

@Conaclos
Thank you for your work:)
In CHANGELOG unresolved conflict is remaining

@Conaclos Conaclos force-pushed the feat/use-consistent-member-accessibility branch from 9fbc308 to 4c03603 Compare August 29, 2024 20:50
@Conaclos Conaclos merged commit bba3412 into biomejs:main Aug 30, 2024
12 checks passed
@seitarof
Copy link
Contributor Author

seitarof commented Sep 2, 2024

@Conaclos
Thank you for your assistance!
I've been too busy with my main job and haven't been able to start on the revision work. I apologize for that 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Changelog Area: changelog A-CLI Area: CLI A-Diagnostic Area: diagnostocis A-Linter Area: linter A-Project Area: project L-JavaScript Language: JavaScript and super languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📎 Implement nursery/useConsistentMemberAccessibility - explicit-member-accessibility
4 participants