refactor(useExportType): don't report export {}
#3542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Linter
Conaclos
force-pushed
the
conaclos/useExportType-empty-export
branch
from
eb2ee5a
to
1b15581
Compare
CodSpeed Performance ReportMerging #3542 will not alter performanceComparing Summary
|
ematipico
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #3535
An empty
export {}allows you to force TypeScript to consider a file with no imports and exports as an EcmaScript module.While
export type {}is valid, it is more common to useexport {}.Users may find it confusing that the linter asks them to convert it to
export type {}.Also, a bundler should be able to remove
export {}as well asexport type {}.So it is not so useful to report
export {}.Test Plan
I updated the tests.