Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly reduce artifacts size #73

Closed
biona001 opened this issue Jun 23, 2024 · 2 comments
Closed

Possibly reduce artifacts size #73

biona001 opened this issue Jun 23, 2024 · 2 comments

Comments

@biona001
Copy link
Owner

biona001 commented Jun 23, 2024

Knockoffs.jl will soon become a dependency for GhostKnockoffGWAS, which will be compiled into a relocatable app.

Knockoffs's dependency LowRankApprox.jl depends on FFTW.jl which in turn depends on MKL_jll.jl which is a staggering 596.668 MiB. Can we remove this dependency?

@biona001
Copy link
Owner Author

We use LowRankApprox.id function which is used in Knockoffs.id_parition_groups to compute group membership. Thus, our option include:

  1. Depreciate support for Knockoffs.id_parition_groups (this is reasonable since for most practical purposes we had used Knockoffs.hc_parition_groups
  2. Copy relevant code of LowRankApprox.id into the current package (probably not a good idea)

@biona001
Copy link
Owner Author

For future reference: from Knockoffs.jl v2.0.0 onwards, we dropped support for id_partition_groups, i.e. option 1 above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant