Replace TravisCI with GitHub Actions #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improvements for the Docker GitHub Action: * Use an automated actions variable for the repo name, instead of hardcoding * Run the functional tests after building and pushing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Great talk at BOSC2020 馃帀
Following our brief chat on BOSC Discord, I thought I would offer some help in switching from Travis CI to GitHub Actions. We've made this change in the @nf_core community because GitHub Actions is automatically enabled for new GitHub repositories and forks and doesn't require users to do any additional steps. In our experience it's also faster and gives a nicer interface in GitHub pull-requests.
Whilst I was here, I also added a workflow to build the Docker image and publish it to the GitHub Package Registry. The same logic applies here - this should work out of the box for any users, and keeps all resources attached to a single repository.
Please note that I have not run any of the original Travis CI tests or used bionitio previously, so this code is purely written by reading what you already had set up. It will probably need some work to (a) get it working and (b) get it to fit in to the bionitio community nicely for other languages.
I hope this helps!
Phil