Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image viewer button settings not saving between launches on latest nightlies #3110

Closed
Wryyyong opened this issue Mar 7, 2024 · 3 comments
Closed
Assignees
Labels
bug duplicate This issue is a duplicate of another issue. reproduced This issue was reproduced by the assignee. ui
Milestone

Comments

@Wryyyong
Copy link

Wryyyong commented Mar 7, 2024

Bug description

Upon launching an instance of 'Grabber', the program fails to load the values set to activeButtons and allButtons within settings.ini, followed by overwriting the aforementioned settings with @Invalid() values.

This results in the buttons in the viewer being completely absent until you get the program to write fresh values to activeButtons and allButtons (even as little as opening the Options dialog and immediately clicking 'OK' out of it will suffice). Following this, the problem will not occur again until 'Grabber' is closed and re-launched.

This has the added effect of needing to re-create your preferred button settings everytime you wish to use the program.

Steps to reproduce

  1. Launch an instance of 'Grabber' by running its executable.
  2. Run a search with any source(s).
  3. Click on any result to open the image viewer.
  4. Notice the lack of buttons inside of the viewer window.

Expected behavior

'Grabber' loading the values saved to activeButtons and allButtons properly, thus allowing for the user's configuration for the buttons to be saved between program launches.

Context

While I won't upload the full logs and settings here, I will include the portions of both relevant to this issue:

  • Immediately following the temp directory purge log, two instances of the following line appear in the log:
[Warning] [Qt][default] QVariant::load: unknown user type with name QList. 
  • Upon launching the program, it failing to load the values before writing to settings.ini results in this:
[Viewer]
activeButtons=@Invalid()
allButtons=@Invalid()

If further information is desired, feel free to ask for it.

System information

  • OS: Windows 10 22H2
  • Grabber version: 7.11.2-a9b8d443
@Wryyyong Wryyyong added the bug label Mar 7, 2024
@Wryyyong Wryyyong changed the title Image window button settings not saving between launches on latest nightlies Image viewer button settings not saving between launches on latest nightlies Mar 7, 2024
@RinMaru
Copy link

RinMaru commented Apr 1, 2024

#3071 think this is the same issue?

@RinMaru
Copy link

RinMaru commented May 12, 2024

still an issue as of the latest release

@Bionus Bionus self-assigned this Jul 20, 2024
@Bionus Bionus added ui reproduced This issue was reproduced by the assignee. labels Jul 20, 2024
@Bionus Bionus added this to the 7.13.0 milestone Jul 20, 2024
@Bionus Bionus added the duplicate This issue is a duplicate of another issue. label Jul 20, 2024
@Bionus
Copy link
Owner

Bionus commented Jul 20, 2024

Thanks for the report and the details provided! They actually helped reproduce and pinpoint the root cause of the issue, so I'll be able to provide a fix ASAP 🎉

Closing as duplicate of issue #3071 though, since even if this one has more details, that one is older, so I'll move the discussion there 👍

@Bionus Bionus closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug duplicate This issue is a duplicate of another issue. reproduced This issue was reproduced by the assignee. ui
Projects
None yet
Development

No branches or pull requests

3 participants