Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefix [FYECO] #268

Closed
matentzn opened this issue Dec 14, 2021 · 8 comments · Fixed by #269
Closed

Add prefix [FYECO] #268

matentzn opened this issue Dec 14, 2021 · 8 comments · Fixed by #269
Assignees
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Prefix

Comments

@matentzn
Copy link
Collaborator

Prefix

fyeco

Name

Fission Yeast Experimental Conditions Ontology

Homepage

https://github.com/pombase/fypo

Description

PomBase manages gene and phenotype data related to Fission Yeast. FYECO contains experimental conditions relevant to fission yeast biology. The FYECO namespace shows up in data ingests from PomBase.

Example Local Unique Identifier

0000003

Regular Expression Pattern for Local Unique Identifier

^\d{7}$

Redundant Prefix in Regular Expression Pattern

FYECO:

URI Format String

http://purl.obolibrary.org/obo/FYECO_

Contributor Name

Val Wood

Contributor ORCiD

0000-0001-6330-7526

Additional Comments

Rather than admitting FYECO to the OBO foundry, we secure the prefix here at bioregistry. The FYECO namespace shows up in a lot of ingests (basically anywhere you ingest PomBase gene-phenotype data). Future work includes mapping FYECO to other OBO ontologies, but this is way ahead in the future. cc @ValWood

@matentzn matentzn added New Used in combination with prefix, metaprefix, or collection for new entries Prefix labels Dec 14, 2021
@cthoyt
Copy link
Member

cthoyt commented Dec 14, 2021

@matentzn I'm not a big fan of using the Bioregistry to resolve to another resolver, I'd prefer to curate the actual URI format string in the Bioregistry. Can you point me to the right place?

Here is an excellent example because FYECO isn't actually registered in the OBO PURL system as far as I can tell.

@matentzn
Copy link
Collaborator Author

There is no URI resolver for FYECO - they wanted to use OBO foundry, but FYECO really should not be in OBO library. The problem is that OBO format itself maps to OBO Foundry purls; so their IRIs will map to that by default. How else will we deal with this issue?

@cthoyt
Copy link
Member

cthoyt commented Dec 14, 2021

Bioregistry doesn't require URI formats, so I think it's better to omit it than put something misleading for FYECO

At some point the Bioregistry could directly ingest the OBO PURL configuration to resolve all of these internally, too.

@matentzn
Copy link
Collaborator Author

Ok great!

Just remove the URI mapping then!

@cthoyt
Copy link
Member

cthoyt commented Dec 14, 2021

The other thing that I don't agree with is that you added Val's information on the contribution - this is actually supposed to refer to Nico's contribution to the bioregisry, not the contact information for the resource. However, I can see how that's confusing, and probably deserves an improvement to the template itself!

@matentzn
Copy link
Collaborator Author

I just copied the information provided by @ValWood, that's all. I didn't actually do anything aside from copy paste, so I think the credit should go to her!

@cthoyt
Copy link
Member

cthoyt commented Dec 14, 2021

Fair enough :)

@ValWood
Copy link
Contributor

ValWood commented Dec 14, 2021

Thanks both.
val

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Used in combination with prefix, metaprefix, or collection for new entries Prefix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants