Skip to content

Commit

Permalink
Hack for calling subprocess on Windows 8.1
Browse files Browse the repository at this point in the history
Thanks to Ben Fulton for testing this, problem found by
test_Applicaion.py failing to call the echo command.
  • Loading branch information
peterjc committed Aug 31, 2015
1 parent 2d2488c commit 780c245
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions Bio/Application/__init__.py
Expand Up @@ -479,14 +479,13 @@ def __call__(self, stdin=None, stdout=True, stderr=True,
# Using universal newlines is important on Python 3, this
# gives unicode handles rather than bytes handles.

# Windows 7 and 8 want shell = True
# platform is easier to understand that sys to determine
# windows version
# Windows 7, 8 and 8.1 want shell = True
# TODO: Test under Windows 10 and revisit platform detection.
if sys.platform != "win32":
use_shell = True
else:
win_ver = platform.win32_ver()[0]
if win_ver in ["7", "8"]:
if win_ver in ["7", "8", "post2012Server"]:
use_shell = True
else:
use_shell = False
Expand Down

0 comments on commit 780c245

Please sign in to comment.