assertRaisesRegexp -> assertRaisesRegex

[peterjc]

The legacy unittest class method assertRaisesRegexp was deprecated in Python 3 in favour of assertRaisesRegex (no trailing p).

https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertRaisesRegex

However, Python 2.7 only has assertRaisesRegexp

https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaisesRegexp

So, once we drop Python 2.7 support in early 2020, we can convert all the trailing p cases.

[dimucciojonathan]

Right here!

[peterjc]

I've just hidden a couple of apparently spam comments from accounts created in the last 24 hours (there was other spam/bot activity over the same time period).

@dimucciojonathan Was your comment in reply to one of those?

[dimucciojonathan]

No, I’m just someone who is looking to get into working with open source projects. Biopython seems like a great project, if you have anything that can be worked on / tested, I’m open to being pointed in the right direction!

…

On Sep 30, 2019, at 4:57 AM, Peter Cock ***@***.***> wrote: I've just hidden a couple of apparently spam comments from accounts created in the last 24 hours (there was other spam/bot activity over the same time period). @dimucciojonathan <https://github.com/dimucciojonathan> Was your comment in reply to one of those? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2273?email_source=notifications&email_token=AMADT2HQT2EIZWS2XVGDISDQMG5QXA5CNFSM4IX6CKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7455HI#issuecomment-536469149>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMADT2DPNMY62QX3SUUDOC3QMG5QXANCNFSM4IX6CKJA>.

[peterjc]

@dimucciojonathan Great. Anything with the "good first issue" tag would be worth a look. This particular issue will have to wait until early 2020 once we've done our final release with Python 2.7 support.

[dimucciojonathan]

Great, I will take a look later today. Thanks for the quick response

…

On Sep 30, 2019, at 12:01 PM, Peter Cock ***@***.***> wrote: @dimucciojonathan <https://github.com/dimucciojonathan> Great. Anything with the "good first issue" tag would be worth a look. This particular issue will have to wait until early 2020 once we've done our final release with Python 2.7 support. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2273?email_source=notifications&email_token=AMADT2FGW3YKDJLV5EP3YDTQMIPGBA5CNFSM4IX6CKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76FK5Y#issuecomment-536630647>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMADT2HVFI2EXCYVWWDZJNTQMIPGBANCNFSM4IX6CKJA>.

[joshuacook487]

Did this end up getting solved? If not I'd be more than happy to take it on?

[dimucciojonathan]

It has not been solved yet, feel free to take over!

…

On Oct 13, 2019, at 4:40 AM, joshuacooked ***@***.***> wrote: Did this end up getting solved? If not I'd be more than happy to take it on? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2273?email_source=notifications&email_token=AMADT2HJSZMDN2PUKQHCWDDQOLNGVA5CNFSM4IX6CKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBCRQSQ#issuecomment-541399114>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMADT2GDD4LCOR7W44AKY4DQOLNGVANCNFSM4IX6CKJA>.

[joshuacook487]

Sweet, I'll get to it.

[peterjc]

It can't be be solved until next year because in the short/medium term we still support Python 2.7, which does not have assertRaisesRegex. Perhaps I didn't word this issue clearly enough?

[joshuacook487]

Yeah, I thought that may be the case. Im new to using Github so I thought the commit could maybe be frozen until 2020. Happy to fix around that date. Until then Ill look for other issues to solve.

…

On Mon, 14 Oct. 2019, 7:36 pm Peter Cock, ***@***.***> wrote: It can't be be solved until next year because in the short/medium term we still support Python 2.7, which does not have assertRaisesRegex. Perhaps I didn't word this issue clearly enough? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2273?email_source=notifications&email_token=AM4ZB6CHGPBA2OMJNZXUVH3QOQVQZA5CNFSM4IX6CKJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBDXP2I#issuecomment-541554665>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM4ZB6DH37KZ55ZP3AWHVELQOQVQZANCNFSM4IX6CKJA> .

[peterjc]

Well, you could make a branch with the changes now - and while there could be no merge conflicts when we come to use it, the chances are it will need manual updating. I'd recommend leaving this issue for now.

[peterjc]

It is nearly 2020, and we have now dropped Python 2 support on the master branch - @joshuacooked if you would like to tackle this now, please go ahead. I appreciate it is holiday season, so no rush.

[mdehoon]

Fixed by #2574