-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip test for QCPSuperimposer if the C module is not compiled #1061
Conversation
The failed Travis CI tests seem unrelated. For,
but fails later on For |
The TravisCI failure is #1059 which could be fixed with a newer version of PyPy... |
PyPy3 is currently failing thus 9a0e2ee - something is wrong in the dependency chain to install and run tox. |
As to the aim of this pull request, we currently expect the user to have compiled Biopython's C code BEFORE running the tests, e.g.
What is your use-case for making the test skip (rather than the current very visible failure)? |
My aim was just for consistency with the other tests: test_KDTree.py , test_PDB_KDTree.py and test_trie.py all give similar errors when their respective C modules are not compiled. |
So they do, good point. Are you happy to dual licence your contributions under both the Biopython License Agreement AND the BSD 3-Clause License? See #898. Also, are you happy to be thanked by name in the |
I have already given my permission to dual license my contributions and I'm happy to be thanked by name in the And thank you for all the work you do for this great piece of bioinformatics software! |
Codecov Report
@@ Coverage Diff @@
## master #1061 +/- ##
==========================================
- Coverage 80.77% 80.77% -0.01%
==========================================
Files 322 322
Lines 49404 49404
==========================================
- Hits 39907 39906 -1
- Misses 9497 9498 +1
Continue to review full report at Codecov.
|
Thank you - acknowledgment in e76b29f |
The QCPSuperimposer test fails with an
ImportError
if the C module is not compiledThis patch adds an
MissingExternalDependencyError
so that the test is skipped if the C module is not compiled.