Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_QCPSuperimposer.py #1110

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Update test_QCPSuperimposer.py #1110

merged 1 commit into from
Mar 23, 2017

Conversation

MaxGreil
Copy link
Contributor

@MaxGreil MaxGreil commented Mar 23, 2017

Converted test_QCPSuperimposer.py to unittests.
Moved printtests from Bio/PDB/QCPSuperimposer/init.py to test_QCPSuperimposer.py and converted it to a unittest.
See biopython issue #820

Converted test_QCPSuperimposer.pyt o unittests.
Moved printtests from Bio/PDB/QCPSuperimposer/__init__.py to test_QCPSuperimposer.py and converted it to a unittest.
See biopython issue #820
@codecov
Copy link

codecov bot commented Mar 23, 2017

Codecov Report

Merging #1110 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1110      +/-   ##
=========================================
+ Coverage    80.8%   80.8%   +<.01%     
=========================================
  Files         322     322              
  Lines       49446   49446              
=========================================
+ Hits        39956   39957       +1     
+ Misses       9490    9489       -1
Impacted Files Coverage Δ
Bio/GA/Evolver.py 54.54% <0%> (-18.19%) ⬇️
Bio/Graphics/Comparative.py 97.33% <0%> (-2.67%) ⬇️
Bio/PDB/QCPSuperimposer/__init__.py 70.65% <0%> (+7.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b1b0e3...7bd9176. Read the comment docs.

@peterjc peterjc merged commit baf6b33 into biopython:master Mar 23, 2017
@peterjc
Copy link
Member

peterjc commented Mar 23, 2017

Thank you :)

Are you happy to dual licence your contributions under both the Biopython License Agreement AND the BSD 3-Clause License? See #898.

Also, are you happy to be thanked by name in the NEWS and CONTRIB files?

@MaxGreil
Copy link
Contributor Author

Hello Peter,
yes, I am happy with both dual licence my contributions as well as be thanked by name.

peterjc added a commit that referenced this pull request Mar 23, 2017
See previous commit, from pull request #1110.
MarkusPiotrowski pushed a commit to MarkusPiotrowski/biopython that referenced this pull request Oct 31, 2017
See previous commit, from pull request biopython#1110.
peterjc added a commit to peterjc/biopython that referenced this pull request Aug 14, 2019
Original author Anuj Sharma (and Thomas Hamelryck whose earlier
superimposer the structure was based on), and all the contributors
since as tracked with version control have agreed:

 - Adhemar Zerlotini (@azneto)
   biopython#1412 (comment)
 - Anuj Sharma (@xulesc)
   biopython#898 (comment)
 - Brian Osborne (@bosborne)
   biopython#898 (comment)
 - Christian Brueffer (@cbrueffer)
   biopython#898 (comment)
 - Brad Chapman (@chapmanb)
   http://mailman.open-bio.org/pipermail/biopython-dev/2013-July/019903.html
 - Connor McCoy (@cmccoy)
   biopython#898 (comment)
 - Jeff Chang (@jefftc)
   biopython#898 (comment)
 - Joe Greener (@jgreener64)
   biopython#1393
 - Maximilian Greil (@MaxGreil)
   biopython#1110
 - Michiel de Hoon (@mdehoon)
   biopython#898 (comment)
 - @morrme
   biopython#1172 (comment)
 - Peter Cock (@peterjc)
   biopython#898 (comment)
 - Sergei Lebedev (@superbobry)
   biopython#898 (comment)
 - Suresh Panneerselvam (@Amrithasuresh)
   biopython#1575
 - Thomas Hamelryck (CVS username nisse)
   https://mailman.open-bio.org/pipermail/biopython/2018-September/016546.html
peterjc added a commit that referenced this pull request Aug 29, 2019
Original author Anuj Sharma (and Thomas Hamelryck whose earlier
superimposer the structure was based on), and all the contributors
since as tracked with version control have agreed:

 - Adhemar Zerlotini (@azneto)
   #1412 (comment)
 - Anuj Sharma (@xulesc)
   #898 (comment)
 - Brian Osborne (@bosborne)
   #898 (comment)
 - Christian Brueffer (@cbrueffer)
   #898 (comment)
 - Brad Chapman (@chapmanb)
   http://mailman.open-bio.org/pipermail/biopython-dev/2013-July/019903.html
 - Connor McCoy (@cmccoy)
   #898 (comment)
 - Jeff Chang (@jefftc)
   #898 (comment)
 - Joe Greener (@jgreener64)
   #1393
 - Maximilian Greil (@MaxGreil)
   #1110
 - Michiel de Hoon (@mdehoon)
   #898 (comment)
 - @morrme
   #1172 (comment)
 - Peter Cock (@peterjc)
   #898 (comment)
 - Sergei Lebedev (@superbobry)
   #898 (comment)
 - Suresh Panneerselvam (@Amrithasuresh)
   #1575
 - Thomas Hamelryck (CVS username nisse)
   https://mailman.open-bio.org/pipermail/biopython/2018-September/016546.html
peterjc added a commit to peterjc/biopython that referenced this pull request Sep 2, 2019
Original author Tarjei Mikkelsen and all the contributors since as tracked
by version control have agreed:

 - Brian Osborne (@bosborne)
   biopython#898 (comment)
 - Carlos Pena (@carlosp420)
   biopython#898 (comment)
 - Chris Rands (@chris-rands)
   biopython#1301
 - Christian Brueffer (@cbrueffer)
   biopython#898 (comment)
 - Connor McCoy (@cmccoy)
   biopython#898 (comment)
 - Francesco Gastaldello (@Gasta88)
   biopython#1063
 - Maximilian Greil (@MaxGreil)
   biopython#1110
 - Peter Cock (@peterjc)
   biopython#898 (comment)
 - Tarjei Mikkelsen (@tmikkelsen)
   biopython#2243 (comment)
peterjc added a commit to peterjc/biopython that referenced this pull request Sep 2, 2019
Original author Tarjei Mikkelsen and all the contributors since as tracked
by version control have agreed:

 - Brian Osborne (@bosborne)
   biopython#898 (comment)
 - Carlos Pena (@carlosp420)
   biopython#898 (comment)
 - Chris Rands (@chris-rands)
   biopython#1301
 - Christian Brueffer (@cbrueffer)
   biopython#898 (comment)
 - Connor McCoy (@cmccoy)
   biopython#898 (comment)
 - Francesco Gastaldello (@Gasta88)
   biopython#1063
 - Maximilian Greil (@MaxGreil)
   biopython#1110
 - Nick Negretti (@nimne)
   biopython#1768 (comment)
 - Peter Cock (@peterjc)
   biopython#898 (comment)
 - Tarjei Mikkelsen (@tmikkelsen)
   biopython#2243 (comment)
peterjc added a commit that referenced this pull request Nov 4, 2019
Original author Tarjei Mikkelsen and all the contributors since as tracked
by version control have agreed:

 - Brian Osborne (@bosborne)
   #898 (comment)
 - Carlos Pena (@carlosp420)
   #898 (comment)
 - Chris Rands (@chris-rands)
   #1301
 - Christian Brueffer (@cbrueffer)
   #898 (comment)
 - Connor McCoy (@cmccoy)
   #898 (comment)
 - Francesco Gastaldello (@Gasta88)
   #1063
 - Maximilian Greil (@MaxGreil)
   #1110
 - Peter Cock (@peterjc)
   #898 (comment)
 - Tarjei Mikkelsen (@tmikkelsen)
   #2243 (comment)
peterjc added a commit that referenced this pull request Nov 4, 2019
Original author Tarjei Mikkelsen and all the contributors since as tracked
by version control have agreed:

 - Brian Osborne (@bosborne)
   #898 (comment)
 - Carlos Pena (@carlosp420)
   #898 (comment)
 - Chris Rands (@chris-rands)
   #1301
 - Christian Brueffer (@cbrueffer)
   #898 (comment)
 - Connor McCoy (@cmccoy)
   #898 (comment)
 - Francesco Gastaldello (@Gasta88)
   #1063
 - Maximilian Greil (@MaxGreil)
   #1110
 - Nick Negretti (@nimne)
   #1768 (comment)
 - Peter Cock (@peterjc)
   #898 (comment)
 - Tarjei Mikkelsen (@tmikkelsen)
   #2243 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants