Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label enhancements in CircularDrawer #116

Closed
wants to merge 1 commit into from

Conversation

davidmam
Copy link

@davidmam davidmam commented Dec 5, 2012

Here are the updated Drawer commits.

@peterjc
Copy link
Member

peterjc commented Mar 16, 2013

Repeating email:
http://lists.open-bio.org/pipermail/biopython-dev/2013-March/010462.html

Hi David,

I've not used your code as is, but have started by pulling out
and generalising what I felt was the least contentious part:

0877125

This means that label_position = start, middle, end (and some
historic aliases defined in the linear drawer code) now work
on circular GenomeDiagrams. I have made the default None,
which gives the current behaviour (as 'start' on linear, the
more complicated to explain vertical bottom on circular).

Support for allowing the default label orientation to be radially
consistent all round the circle (rather than the current flipping
for the left/right halves which assumes the output is kept
vertical) would be nice, but the thing I am most keen on is the
inside/outside of the track label placement. Hopefully I'll have
time to finish that this weekend...

Peter

@peterjc
Copy link
Member

peterjc commented Aug 29, 2013

With the changes included in Biopython 1.62 (and its beta), I think we can close this pull request now, OK?

@peterjc peterjc closed this Sep 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants