Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch blast 2.2.27+ wrapper #151

Closed
wants to merge 4 commits into from

Conversation

bow
Copy link
Member

@bow bow commented Feb 1, 2013

@peterjc
Copy link
Member

peterjc commented Feb 3, 2013

I've applied 3 of the 4 commits, tested with BLAST 2.2.26+ which meant a little modification to test_NCBI_BLAST_tools.py as done previously - the primary goal of the CheckCompleteArgList class is really just to alert us to when the wrapper needs updating.

I'm not sure we should just remove the -frame_shift_penalty option as it still exists on the older versions of BLAST+, probably just adding a comment about this to the docstring would suffice (and ignore this in test_NCBI_BLAST_tools.py)?

@bow
Copy link
Member Author

bow commented Feb 3, 2013

To maintain compatibility with older BLAST+ versions, yes, I agree we should keep the obsolete command line args.

I was probably taking the warnings too seriously and removed these extra arguments. And yes, a note in the docstring should suffice.

@peterjc
Copy link
Member

peterjc commented Feb 4, 2013

Done: 63997ea

Thanks

@peterjc peterjc closed this Feb 4, 2013
@bow
Copy link
Member Author

bow commented Feb 4, 2013

Great :), thanks Peter.

@bow bow deleted the patch_blast-2.2.27+-wrapper branch July 8, 2015 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants