KGML files #155
Closed
KGML files #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First addition of Bio.KGML module, with Bio.Graphics.KGML_vis and unit test in Bio.Tests.
Split single KGML test to online, graphics, and nographics tests. Moved Bio.KGML to Bio.KEGG.KGML.
There are still TODOs when drawing relations as arrows. This ability is commented out for now.
Removed *stupidly* committed files
Also removes Bio.ParserSupport.SGMLStrippingConsumer
i.e. This change makes the deprecated aliases read only, and adds an explicit warning when reading the values. Previously only got a warning on setting the value via the deprecated alias.
No code changes, don't need TravisCI to test this: [ci skip]
|
Cleaned up branch here - squashing Leighton's commits into one (getting rid of the confusion of the accidentally added then removed files) on the current master: We need to review this in conjunction with @kevin's KEGG API work: |
|
I've updated the Git ignore listing which would have prevented your accidental check in of the biopython.egg-info files - so that was a useful mistake: |
|
We can continue discussion on this pull request based on the cleaned up branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed - not an ideal pull request (rebasing added the recent Biopython changes to the KEGG branch, rather than what was expected), but if it's workable, here's the code in a way that doesn't seem to break Biopython ;)
L.