Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide just default alphabet in Seq __repr__ #1687

Merged
merged 1 commit into from Jun 20, 2018

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented Jun 14, 2018

This pull request addresses issue #1674, taking part of the work on #1676, which expanded in scope to remove the alphabet from the Seq-objects' __repr__ completely.

This only hides the alphabet if it is the default alphabet. I would like to include this in Biopython 1.72

I hereby agree to dual licence this and any previous contributions under both the Biopython License Agreement AND the BSD 3-Clause License.

I have read the CONTRIBUTING.rst file and understand that AppVeyor and TravisCI will be used to confirm the Biopython unit tests and flake8 style checks pass with these changes.

I have added my name to the alphabetical contributors listings in the files NEWS.rst and CONTRIB.rst as part of this pull request, am listed already, or do not wish to be listed. (This acknowledgement is optional.)

@codecov
Copy link

codecov bot commented Jun 14, 2018

Codecov Report

Merging #1687 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
- Coverage   85.52%   85.46%   -0.06%     
==========================================
  Files         327      327              
  Lines       50039    50082      +43     
==========================================
+ Hits        42795    42805      +10     
- Misses       7244     7277      +33
Impacted Files Coverage Δ
Bio/Seq.py 98.12% <100%> (+0.02%) ⬆️
Bio/Blast/NCBIWWW.py 9.24% <0%> (-2.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e1dc3...1d75e12. Read the comment docs.

@peterjc peterjc merged commit d13441c into biopython:master Jun 20, 2018
@peterjc peterjc deleted the hide_def_alphabet branch June 20, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants