Move Bio/.flake8 to top level #2018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still have other folder specific .flake8 files, but plan is to improve the compliance in Tests/ etc and have a single set of flake8 settings here. This will allow use to simplify how we run flake8, and use its provided git pre-commit hook.
Codecov Report
@@ Coverage Diff @@
## master #2018 +/- ##
======================================
Coverage 85.1% 85.1%
======================================
Files 314 314
Lines 50302 50302
======================================
Hits 42809 42809
Misses 7493 7493Continue to review full report at Codecov.
|
|
See my last comment on #2014 regarding the |
|
Yes, that's a better solution with flake 3.7 onwards offering more configuration options: #2014 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work intended to help with #493 and #2014 - fairly sure the automated tests will work without changing the TravisCI/Tox setup, about to find out...
Still have other folder specific .flake8 files, but plan is to improve the compliance in Tests/ etc and have a single set of flake8 settings here.
This will allow use to simplify how we run flake8, and use its provided git pre-commit hook.
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile and understand that AppVeyor andTravisCI will be used to confirm the Biopython unit tests and
flake8stylechecks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)