Introduce charge_at_pH functionality in ProteinAnalysis (and IsoelectricPoint) #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPiotrowski
force-pushed
the
charge_at_pH
branch
from
f0e502f
to
6566967
Compare
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
=========================================
+ Coverage 84.84% 84.95% +0.1%
=========================================
Files 321 318 -3
Lines 51765 51061 -704
=========================================
- Hits 43922 43377 -545
+ Misses 7843 7684 -159
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2096 +/- ##
==========================================
- Coverage 84.92% 84.92% -0.01%
==========================================
Files 321 321
Lines 52002 51957 -45
==========================================
- Hits 44162 44123 -39
+ Misses 7840 7834 -6
Continue to review full report at Codecov.
|
|
I don't know enough about the application area to really judge, but it looks like @dcroote liked it. You'll have to solve the conflict, but I guess go ahead with the merge 👍 |
MarkusPiotrowski
force-pushed
the
charge_at_pH
branch
from
6566967
to
46422cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #2002. Code in
IsoelectricPointwas re-organized and a new public methodcharge_at_pH(pH)was added (making use of the private method_chargeR(pH)). This method calculates the charge of a protein at a given pH. Access to this method was also added toBio.SeqUtils.ProtParam.ProteinAnalysis.This PR will close #2002.
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runflake8locally, andunderstand that AppVeyor and TravisCI will be used to confirm the Biopython unit
tests and style checks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)
PS: Sorry, didn't want to upvote my own PR, strange that this is working...