Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Bio.Index #2205

Merged
merged 1 commit into from Aug 19, 2019
Merged

Deprecate Bio.Index #2205

merged 1 commit into from Aug 19, 2019

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented Aug 9, 2019

This pull request addresses issue #...

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run flake8 locally, and
    understand that AppVeyor and TravisCI will be used to confirm the Biopython unit
    tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #2205 into master will increase coverage by 1.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2205      +/-   ##
==========================================
+ Coverage   83.31%   84.68%   +1.37%     
==========================================
  Files         316      317       +1     
  Lines       51217    51451     +234     
==========================================
+ Hits        42671    43573     +902     
+ Misses       8546     7878     -668
Impacted Files Coverage Δ
Bio/Index.py 34.14% <100%> (+2.5%) ⬆️
Bio/SearchIO/_model/query.py 91.5% <0%> (-0.93%) ⬇️
Bio/PDB/mmtf/DefaultParser.py 100% <0%> (ø)
Bio/SearchIO/HHsuiteIO/hhsuite2_text.py 97.03% <0%> (+0.02%) ⬆️
Bio/Align/__init__.py 87.43% <0%> (+0.03%) ⬆️
Bio/GenBank/Scanner.py 82.8% <0%> (+0.04%) ⬆️
Bio/SeqIO/InsdcIO.py 93.08% <0%> (+0.04%) ⬆️
Bio/AlignIO/MafIO.py 92.92% <0%> (+0.04%) ⬆️
Bio/Phylo/Consensus.py 83.1% <0%> (+0.05%) ⬆️
Bio/GenBank/__init__.py 93.76% <0%> (+0.06%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6037361...7e2fa4c. Read the comment docs.

@peterjc
Copy link
Member Author

peterjc commented Aug 12, 2019

No replies on the mailing list yet either:
https://mailman.open-bio.org/pipermail/biopython/2019-August/016655.html

@peterjc peterjc requested a review from mdehoon August 12, 2019 16:25
@peterjc peterjc merged commit 433e369 into biopython:master Aug 19, 2019
@peterjc peterjc deleted the dep_index branch August 19, 2019 14:30
@peterjc peterjc mentioned this pull request Dec 25, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant