Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bio.SVDSuperimposer cleanup to remove nested module name #242

Closed
wants to merge 4 commits into from

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented Sep 29, 2013

This was prompted by having to fix an import * in this area of the code, and the recollection of epydoc complaining about the class and sub-module name clashing (one shadows the other making imports confusing).

This pull request essentially moves the code in Bio/SVDSuperimposer/SVDSuperimposer.py into Bio/SVDSuperimposer/__init__.py from where is was typically imported anyway.

As explained in the DEPRECATED file, this could break some existing code doing long-winded imports, but the standard import is not affected (and probably most users import it via Bio.PDB anyway and won't be affected at all).

@etal
Copy link
Contributor

etal commented Sep 30, 2013

Looks good to me. Relatedly, a line in test_SVDSuperimposer.py can be safely changed from:

from Bio.SVDSuperimposer import *

to:

from Bio.SVDSuperimposer import SVDSuperimposer

because the only contents of the module are the SVDSuperimposer class and a *-full of numpy imports, which are already separately imported into the test script.

@peterjc
Copy link
Member Author

peterjc commented Oct 1, 2013

Rebased & applied, plus the import fix suggested by Eric on the mailing list:
c8dfe46

@peterjc peterjc closed this Oct 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants