New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added FALDO based position/location serialization. #346
Conversation
A discussion about improving the implementation has been started for the corresponding BioRuby pull request: bioruby/bioruby#95 |
…racters that can be used in labels too.
Latest build failure seems to be due to a network connection problem in one of the environments -- not due to latest commit. |
Does this consider compound locations (joins in GenBank/EMBL terminology)? |
Are those covered by classes in the SeqFeature file? If so, then yes, otherwise, possibly not. |
Class |
Right. I remember now. I did not implement CompoundLocation because it was more complex. |
Yep - property bags/lists required... |
Actually, I re-read the Turtle spec recently and the use of lists is well supported in that format (lots of syntactic sugar provided). If it is only about using an RDF list, then this could be implemented rather elegantly and quickly. |
This rebases cleanly onto the current master; I've also removed some unneeded imports in My work in progress is here (which I will likely rebase from time to time): https://github.com/peterjc/biopython/tree/faldo |
… but unclear how to represent the list of regions.
I have implemented a preliminary -- possibly incomplete -- RDFization of CompoundLocation objects. @peterjc Please have a look at the use of rdfs:member. I recall there was a discussion about swapping a FALDO doman/range restriction, which might apply here, but I cannot find that discussion anymore. If RDFized like I implemented it, it is currently not clear to me how I arrange the FeatureLocation objects in a list. |
See range/domain discussion at OBF/FALDO@43834f4 - fixed as of OBF/FALDO@4cd5bba which was merged (it should be range). |
Is seems an additional RDF tuple is required to link the generated FALDO location to the feature it belongs to. Perhaps the RDF method needs to return two values, the FALDO string as now, plus the URI of the location (or compound location) which the caller can then use? |
No description provided.