Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FALDO based position/location serialization. #346

Closed
wants to merge 4 commits into from
Closed

Added FALDO based position/location serialization. #346

wants to merge 4 commits into from

Conversation

KimJBaran
Copy link

No description provided.

@KimJBaran
Copy link
Author

A discussion about improving the implementation has been started for the corresponding BioRuby pull request: bioruby/bioruby#95

@KimJBaran
Copy link
Author

Latest build failure seems to be due to a network connection problem in one of the environments -- not due to latest commit.

@peterjc
Copy link
Member

peterjc commented Aug 5, 2014

Does this consider compound locations (joins in GenBank/EMBL terminology)?

@KimJBaran
Copy link
Author

Are those covered by classes in the SeqFeature file? If so, then yes, otherwise, possibly not.

@peterjc
Copy link
Member

peterjc commented Aug 5, 2014

Class CompoundLocation defined in SeqFeature.py does not have a new ._rdfize(...) method (like class FeatureLocation and most of the position classes).

@KimJBaran
Copy link
Author

Right. I remember now. I did not implement CompoundLocation because it was more complex.

@peterjc
Copy link
Member

peterjc commented Aug 5, 2014

Yep - property bags/lists required...

@KimJBaran
Copy link
Author

Actually, I re-read the Turtle spec recently and the use of lists is well supported in that format (lots of syntactic sugar provided). If it is only about using an RDF list, then this could be implemented rather elegantly and quickly.

@peterjc
Copy link
Member

peterjc commented Nov 11, 2014

This rebases cleanly onto the current master; I've also removed some unneeded imports in test_RDF.py and applied some PEP8 style changes (part of a general house keeping we're working on for the whole code base, see #406).

My work in progress is here (which I will likely rebase from time to time): https://github.com/peterjc/biopython/tree/faldo

… but unclear how to represent the list of regions.
@KimJBaran
Copy link
Author

I have implemented a preliminary -- possibly incomplete -- RDFization of CompoundLocation objects.

@peterjc Please have a look at the use of rdfs:member. I recall there was a discussion about swapping a FALDO doman/range restriction, which might apply here, but I cannot find that discussion anymore.

If RDFized like I implemented it, it is currently not clear to me how I arrange the FeatureLocation objects in a list.

@peterjc
Copy link
Member

peterjc commented Nov 20, 2014

See range/domain discussion at OBF/FALDO@43834f4 - fixed as of OBF/FALDO@4cd5bba which was merged (it should be range).

@peterjc
Copy link
Member

peterjc commented Nov 20, 2014

Is seems an additional RDF tuple is required to link the generated FALDO location to the feature it belongs to. Perhaps the RDF method needs to return two values, the FALDO string as now, plus the URI of the location (or compound location) which the caller can then use?

@KimJBaran KimJBaran closed this Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants