Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the OBF Code of Conduct #3866

Merged
merged 1 commit into from Jun 22, 2022
Merged

Adopt the OBF Code of Conduct #3866

merged 1 commit into from Jun 22, 2022

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented Feb 15, 2022

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run pre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

See:

Note that to match the other Biopython top level text files I have used CODE_OF_CONDUCT.rst rather than CODE_OF_CONDUCT.md as suggested by GitHub: https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-code-of-conduct-to-your-project

@peterjc
Copy link
Member Author

peterjc commented Feb 15, 2022

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #3866 (546de26) into master (4d37d81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3866   +/-   ##
=======================================
  Coverage   84.29%   84.29%           
=======================================
  Files         322      322           
  Lines       55044    55044           
=======================================
  Hits        46400    46400           
  Misses       8644     8644           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d37d81...546de26. Read the comment docs.

@peterjc
Copy link
Member Author

peterjc commented Feb 15, 2022

Cross reference bioperl/bioperl-live#366 for BioPerl

@JoaoRodrigues
Copy link
Member

Nothing to add to the text itself. My only comment would be that it would be nice to have the actual CoC file on our repository, but I see the advantages of having it centralized in the OBF repo and then linked to (updates, etc).

@peterjc
Copy link
Member Author

peterjc commented Feb 16, 2022

Yes, having the text directly in the Biopython repository would be nice, but then we need a mechanism to keep it in sync with the central copy. A short human readable file directing readers to the central copy seemed best.

@peterjc
Copy link
Member Author

peterjc commented Jun 22, 2022

There were no further comments on the mailing list either since https://mailman.open-bio.org/pipermail/biopython/2022-April/016934.html

@peterjc peterjc merged commit 289ddb5 into master Jun 22, 2022
@peterjc peterjc deleted the code-of-conduct branch June 22, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants