Remove sys.path hack in run_tests to avoid issues with compiled code #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why appveyor would fail, since all windows tests pass on GHA.. However, is the purpose of the Appveyor workflow to 1) test BioSQL and 2) upload the coverage results to codecov? These could be moved to GHA as well. EDIT: |
|
That makes sense. So we can no longer do this on a clean machine: Being able to test before install is helpful, but not essential given how most people now install pre-compiled wheels or other packages. |
npars
added a commit
to npars/biopython
that referenced
this pull request
May 20, 2022
- PR biopython#3912 introduced changes that broke the existing testing instructions - Update testing instructions to work with latest test scripts - Test instructions now work with setup.py script as well as through the Intellij test runner
3 tasks
JoaoRodrigues
added a commit
to cbalbin-bio/biopython
that referenced
this pull request
Aug 7, 2022
…ness (biopython#3912) - Remove sys.path hacking from `run_tests` - Update CI workflow to use `pip` instead of `python setup.py install` - Force-update build dependencies (setuptools, pip, wheel) across all 3 OSes.
peterjc
pushed a commit
that referenced
this pull request
Oct 21, 2022
- PR #3912 introduced changes that broke the existing testing instructions - Update testing instructions to work with latest test scripts - Test instructions now work with setup.py script as well as through the Intellij test runner
peterjc
added a commit
to peterjc/biopython
that referenced
this pull request
Apr 6, 2023
Should have done this around the time of biopython#3937, old method broke as a result of biopython#3912
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to dual licence this and any previous contributions under both
the Biopython License Agreement AND the BSD 3-Clause License.
I have read the
CONTRIBUTING.rstfile, have runpre-commitlocally, and understand that continuous integration checks will be used to
confirm the Biopython unit tests and style checks pass with these changes.
I have added my name to the alphabetical contributors listings in the files
NEWS.rstandCONTRIB.rstas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)
If the CI passes (this is the only way to test), this patch closes #3910.