Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry block for HTTPError 5xx from Entrez.efetch() #436

Closed
wants to merge 4 commits into from
Closed

Add retry block for HTTPError 5xx from Entrez.efetch() #436

wants to merge 4 commits into from

Conversation

vincentdavis
Copy link
Contributor

Add try > except > pause > retry block for HTTPError 5xx type errors for Entrez.efetch() batch example

Add try > except > pause > retry block for HTTPError 5xx type errors for Entrez.efetch() batch example
Added try>except>pause>retry to the Searching for and downloading
abstracts using the history example
@vincentdavis
Copy link
Contributor Author

I think this is ready

@peterjc
Copy link
Member

peterjc commented Dec 17, 2014

Sorry, didn't see those changes.

What I meant above was while we would use Bio._py3k inside Biopython to import the HTTPError, this is intended as a private interface and so should not be used in our user documentation. Thus the try/except would be the neatest solution.

@vincentdavis
Copy link
Contributor Author

Ok, done, or at least in need of another review.

@peterjc
Copy link
Member

peterjc commented Dec 19, 2014

Applied as the single commit e2ed045 with one minor tweak 48fdd80 - thanks :)

@peterjc peterjc closed this Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants