Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore author list to Tutorial, fix up the bibliography #4573

Merged
merged 11 commits into from
Jan 9, 2024

Conversation

peterjc
Copy link
Member

@peterjc peterjc commented Jan 5, 2024

  • I hereby agree to dual licence this and any previous contributions under both
    the Biopython License Agreement AND the BSD 3-Clause License.

  • I have read the CONTRIBUTING.rst file, have run pre-commit
    locally, and understand that continuous integration checks will be used to
    confirm the Biopython unit tests and style checks pass with these changes.

  • I have added my name to the alphabetical contributors listings in the files
    NEWS.rst and CONTRIB.rst as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

CC @idoerg

Copied from Doc/Tutorial.tex as of v1.82
prior to the LaTeX to RST conversion.

(This seems a better placement than in
the copyright footer as per the theme.)
My ad hoc LaTeX BibItem to RST script didn't cope
with the accents.
@peterjc
Copy link
Member Author

peterjc commented Jan 5, 2024

I've worked out why the [Kent2002] and [Matys2003] entries show with extra indentation: https://biopython.org/docs/dev/Tutorial/chapter_bibliography.html

They start with an initial dot space. Now how to fix this...

Update See https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#enumerated-lists - could split the line, or escape the letter or the dot.

This stops the line being treated as a single
entry alphabetically enumerated list. See
https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#enumerated-lists

i.e. Fixed the unwanted indentation.
Was pointing at the correction DOI
for adding two missing references.
@peterjc
Copy link
Member Author

peterjc commented Jan 5, 2024

@mdehoon your eyes on this might be helpful, particularly is the current capitalisation of "de Hoon" OK?

(Under LaTeX all the bibliography keys were lower case but not user facing; now they are user facing and I picked deHoon2004 rather than DeHoon2004)

This appears to avoid a subtle bug in Sphinx
generating invalid LaTeX with symbol footnotes.
Automatically numbered footnotes are fine though.

Tested on macOS using:

Sphinx==4.3.2
sphinx-rtd-theme==1.3.0

and:

$ make latexpdf
@peterjc peterjc requested a review from bow as a code owner January 5, 2024 19:17
This works, is readable, but not as pretty as I'd
like. We might use the maketitle setting to setup
the entire PDF title page ourselves?

Note that as far as I can see, the author field
has no effect on the HTML output, thus we now have
a duplicated author listing in the index.rst file,
which is not ideal.
@peterjc
Copy link
Member Author

peterjc commented Jan 5, 2024

Good news: PDF output is looking much better now, although I'd like the title page to look nicer. This includes the author list.

Bad news: There is no equivalent title page in the HTML output.

So, by inserting the author list explicitly (currently above the Tutorial table of contents), it appears once in the HTML and twice in the PDF. And we have to keep the two in sync. That will have to do in the short term.

These didn't render nicely in the HTML, and to me
added nothing over the HTML output's TOC.

Seems to have no effect on the PDF output (which
still has indices which look much better).
@mdehoon
Copy link
Contributor

mdehoon commented Jan 6, 2024

@mdehoon your eyes on this might be helpful, particularly is the current capitalisation of "de Hoon" OK?

(Under LaTeX all the bibliography keys were lower case but not user facing; now they are user facing and I picked deHoon2004 rather than DeHoon2004)

Thanks @peterjc , this always confuses everybody.
In Dutch, capitalization depends on the grammatical context. Specifically, the letter appearing first in the name should be capitalized. So it is "Mr. Van Gogh" but "Mr. Vincent van Gogh".
Then I guess "DeHoon2004" makes more sense, but either way is fine.

Quoting feedback on the pull request:

In Dutch, capitalization depends on the grammatical
context. Specifically, the letter appearing first
in the name should be capitalized. So it is "Mr.
Van Gogh" but "Mr. Vincent van Gogh". Then I guess
"DeHoon2004" makes more sense, but either way is fine.
@peterjc peterjc merged commit 1424a23 into biopython:master Jan 9, 2024
35 checks passed
@peterjc peterjc deleted the authors branch January 9, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants