Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent coordinate specification for Maf alignment access in MafIO.py #504

Closed
wants to merge 24 commits into from

Commits on Jan 11, 2017

  1. Added MafIO.py genome alignment format parser.

    The module parses MAF formatted files (https://cgwb.nci.nih.gov/FAQ/FAQformat.html#format5).
    
    This is mainly meant to be used through MafIndex.search and
    MafIndex.get_spliced methods, which, at this stage, expect lists of
    start and end coordinates, where both starts and ends are zero-based
    inclusive (0 is the first alignment position). To ask for the alignment
    portion corresponding to the first 100 nucleotides of the reference
    sequence, you would use MafIndex.get_spliced([0], [99])
    
    As I commented in the pull request discussion
    (biopython#504 (comment)):
    
    > I decided to do "zero-based" because MAF format is zero-based. But I
    > decided to make the end coordinate inclusive, because it is not very
    > intuitive for the human user to have to provide a list of "inclusive"
    > start coordinates, but "exclusive" end coordinates when calling
    > MafIndex.search and MafIndex.get_spliced.
    
    This commit is based on work by the following contributors (the commits
    have been squashed during rebase):
    
    https://github.com/polyatail
    https://github.com/peterjc
    https://github.com/adamnovak
    https://github.com/blaiseli
    polyatail authored and blaiseli committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    a6c0bb4 View commit details
    Browse the repository at this point in the history
  2. Added more details in search and get_spliced doc.

    Also tried to fix style issues (as reported by pylint).
    blaiseli committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    e2f0987 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4455004 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2fc9b04 View commit details
    Browse the repository at this point in the history
  5. Reverted to MafIterator, removed Generic.Alignment

    I had renamed MafIterator to maf_iterator to respect style conventions,
    but this conflicts with other Bio* conventions.
    blaiseli committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    9ab25d2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    650abdb View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2017

  1. Configuration menu
    Copy the full SHA
    c6bdbb6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e2f2744 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7807540 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2017

  1. Configuration menu
    Copy the full SHA
    d5397c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2017

  1. Configuration menu
    Copy the full SHA
    be7194a View commit details
    Browse the repository at this point in the history
  2. Fixed error introduced while resolving conflicts.

    Reverted inefficient "avoid dots" technique.
    blaiseli committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    37c218a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b3e234 View commit details
    Browse the repository at this point in the history
  4. Re-establishing lost-during-merge edits:

    - from commit 49e7da7:
    
        Remove unwanted white space after docstrings (etc)
    
        $ pydocstyle Bio/ BioSQL/ Tests/ Scripts/ Doc/ --select D202
        ...
        D202: No blank lines allowed after function docstring
    
    - from commit a8cf8c0:
    
        Avoid ValueError for file not found
    
        Aim here was to be user friendly, but a file-system relevant
        exception is probably better for error handling.
    blaiseli committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    055ee12 View commit details
    Browse the repository at this point in the history
  5. Removed some useless code.

    blaiseli committed Feb 24, 2017
    Configuration menu
    Copy the full SHA
    c09e6a7 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2017

  1. Configuration menu
    Copy the full SHA
    f7253b9 View commit details
    Browse the repository at this point in the history
  2. Set MAFINDEX_VERSION to 2.

    blaiseli committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    7c3c0da View commit details
    Browse the repository at this point in the history
  3. Updated MAF indices.

    blaiseli committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    f729d65 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    31123f7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2391ca6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a622f21 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9fe3c5a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    02dfd2f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ef73b3a View commit details
    Browse the repository at this point in the history