Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion into matchms #4

Open
florian-huber opened this issue Feb 21, 2023 · 3 comments
Open

Inclusion into matchms #4

florian-huber opened this issue Feb 21, 2023 · 3 comments
Assignees

Comments

@florian-huber
Copy link

Nice that your approach works so much faster than the conventional way of computing Cosine scores,
And, most of all, that it seems to work well as a potential pre-filter to select candidates with potentially high cosine scores!

This would obviously be a very nice addition to matchms.
I could implement it on the matchms side, but it would need more testing (preferentially right here, otherwise in matchms).
Let me know if I can help with setting up tests and continuous integration.

@tharwood3 tharwood3 self-assigned this Feb 21, 2023
@tharwood3
Copy link
Collaborator

Thanks @florian-huber! Inclusion in matchms would be great. We will build up our testing suite and continuous integration and keep you in the loop.

@YUANMENG-1
Copy link

YUANMENG-1 commented Mar 5, 2024

Excuse me, every time i try the "conda env create -f environment.yml", it will stop in solving environment here in the picture, and finally failed to continue, I remember last year I also met this problem and failed to try blink, and I install all the dependency before running the environment.yml
and whether in HPC or mac all met this
image

@benbowen
Copy link
Member

benbowen commented Mar 5, 2024

Hi @YUANMENG-1, I'm sorry to hear you are having conda trouble. Can you open a new ticket please? This ticket is specific to our long-term goal of getting BLINK into MatchMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants