Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support consuming TRAPI v1.1 APIs #18

Closed
newgene opened this issue May 10, 2021 · 7 comments
Closed

support consuming TRAPI v1.1 APIs #18

newgene opened this issue May 10, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@newgene
Copy link
Member

newgene commented May 10, 2021

Note a few small query graph property name changes:

https://github.com/NCATSTranslator/ReasonerAPI/blob/master/ChangeLog.md

@newgene newgene added the enhancement New feature or request label May 10, 2021
@newgene newgene changed the title support TRAPI v1.1 APIs support consuming TRAPI v1.1 APIs May 10, 2021
@newgene
Copy link
Member Author

newgene commented May 24, 2021

  • need to consume new /meta_knowledge_graph endpoint to get the predicates information
  • update input query graph to use new v1.1 format (mostly change word to its plural)

@newgene
Copy link
Member Author

newgene commented Jun 1, 2021

@newgene
Copy link
Member Author

newgene commented Jun 8, 2021

Also test an actual TRAPI query to a specific http://api.bte.ncats.io/v1/smartapi/<api_id>/query URL to confirm it's working.

@marcodarko
Copy link
Contributor

Update:
OpenPredict (trapi 1.1.0) works for testing this endpoint:
https://api.bte.ncats.io/v1/smartapi/e9f69b81e755e163fdf6c41a2b5e07c0/meta_knowledge_graph

However, the previous test url provided uses Automat KEGG (trapi 1.1.0) and it does not work (but should), it appears that this API is not making it into the specs file collected by our cron job that looks at the registry. We need to investigate why that is.

@marcodarko
Copy link
Contributor

@andrewsu @newgene I think the reason that API (Automat KEGG ) doesn't appear is because they have "/1.1/meta_knowledge_graph" instead of "/meta_knowledge_graph" thus failing our check and not being included. What should we do about it?

@marcodarko
Copy link
Contributor

*Note on why some of these APIs don't work for this endpoint: /v1/<ID>/meta_knowledge_graph
This endpoint will ultimately look through the specs.json (response from a query to SmartAPI for all translator APIs) for this API and look in the paths for a property "x-bte-kgs-operations" in them, if that is not found the operations returned will be 0 and that triggers an "error" on our side but it simply means that nothing was found. As I understand, this was the old way to specify operations now moved to its own endpoint: /meta_knowledge_graph . How do we want to handle such cases? or is this endpoint going to be deprecated at some point?

@colleenXu
Copy link
Contributor

Can this issue be closed? I have another one currently open that's related...biothings/biothings_explorer#269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants