Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working for Bing Chat #1130

Closed
nicolasmaia opened this issue Apr 6, 2023 · 4 comments · Fixed by #1141
Closed

Not working for Bing Chat #1130

nicolasmaia opened this issue Apr 6, 2023 · 4 comments · Fixed by #1141

Comments

@nicolasmaia
Copy link

nicolasmaia commented Apr 6, 2023

10ten doesn't work on https://www.bing.com/search?q=Bing+AI

You might need either Edge or a useragent spoofer to be able to use Bing Chat, though

@birtles
Copy link
Member

birtles commented Apr 8, 2023

Thanks for reporting this. I can reproduce it. I'll look into it next week.

@birtles
Copy link
Member

birtles commented Apr 10, 2023

Seems to work fine in Firefox with a useragent spoof, but not in Edge.

Looks like it's related to Chromium not digging into shadow DOM for caretRangeFromPoint (and not supporting caretPositionFromPoint at all). Test case: https://8t4urf.codesandbox.io/

@birtles
Copy link
Member

birtles commented Apr 10, 2023

Seems like Safari has the same problem. Even document.elementsFromPoint doesn't dig into shadow trees. Instead we'll need to recursively do element(s)FromPoint on each shadow root until we get to some text. This could be quite a bit of work.

birtles added a commit that referenced this issue Apr 15, 2023
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
@birtles
Copy link
Member

birtles commented Apr 19, 2023

I've made some progress on this. It can now dig into these nested shadow DOM trees fairly successfully but it doesn't successfully mimic the layout of the shadow DOM content in a lot of cases. As a result in Bing chat, you can scan simple sentences, but once the footnote annotations appear they throw off the layout. It should be fixable but it's going to take a bit more work yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants