Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect popup handling in flexbox elements #990

Closed
Tomalak opened this issue Sep 13, 2022 · 4 comments · Fixed by #1136
Closed

Incorrect popup handling in flexbox elements #990

Tomalak opened this issue Sep 13, 2022 · 4 comments · Fixed by #1136

Comments

@Tomalak
Copy link

Tomalak commented Sep 13, 2022

On Hikibiki, this happens in 1.12.4:

Animation
@birtles
Copy link
Member

birtles commented Sep 13, 2022

Thanks for filing this! That's definitely weird.

@birtles
Copy link
Member

birtles commented Sep 14, 2022

This appears to be an existing issue, as opposed to a recent regression.

It looks like the logic we have for re-using the last result fails to perform the distance check we use when we do a new lookup. We could just always perform that distance check, but it will likely hurt performance since we'll flush layout more often. I think we need to cache the position of the text and check that before re-using a previous result.

@birtles birtles mentioned this issue Apr 12, 2023
Merged
birtles added a commit that referenced this issue Apr 15, 2023
@birtles
fix: overhaul text lookup
7b50e67 
Rewrite text lookup to be more thorough and robust.

Fixes #990.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 15, 2023
@birtles
fix: overhaul text lookup
958c0a2 
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
@birtles
fix: overhaul text lookup
ad46955 
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
@birtles
fix: overhaul text lookup
4b7c3a0 
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
birtles added a commit that referenced this issue Apr 17, 2023
@birtles
fix: overhaul text lookup
34db842 
Completely overhaul text lookup to cover more cases and (hopefully) be
easier to extend in future (so we can tackle #1130).

Fixes #990.
Fixes #1033.

Also improves performance and allows looking up `user-select: all` text
in Firefox.
@Tomalak
Copy link
Author

Tomalak commented Apr 18, 2023

This seems to have been an incredibly involved fix/rewrite. Thank you!

@birtles
Copy link
Member

birtles commented Apr 18, 2023

Thank you! Yeah, it was three solid days of work. Hopefully it makes it possible to fix #1130 and other bugs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: rewrite text scanning birchill/10ten-ja-reader
2 participants
@Tomalak @birtles