Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely overhaul text lookup to cover more cases and be (hopefully) easier to
extend in future (so we can tackle #1130).
Fixes #990.
As mentioned in the discussion for #990, this has a negative performance impact
for most content. This is due to the extra distance calculations performed on
each lookup which is needed to avoid returning a cached position when the
distance has substantially changed.
For some content such as asahi.com, however, there is a net performance
improvement due to the way we handle repeated lookups.
For now this is probably acceptable, but if not, we will need to find a way to
cache the point used as input for the previous lookup and avoid doing distance
calculations if we determine we are close.