Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration has no effect due to wrong indentation #4262

Closed
joemull opened this issue Jun 7, 2024 · 0 comments · Fixed by #4263
Closed

Migration has no effect due to wrong indentation #4262

joemull opened this issue Jun 7, 2024 · 0 comments · Fixed by #4263
Assignees
@joemull
Labels
bug Something's not working priority-high High priority
Milestone
v1.5.6

Comments

@joemull
Copy link
Member

joemull commented Jun 7, 2024

The operations variable needs to be an attribute of the Migration class:

https://github.com/BirkbeckCTP/janeway/blob/8bcccdbb9cdb9327d40feff1fc65973187c218e2/src/core/migrations/0088_fix_untyped_galleys.py#L7-L33
@joemull joemull added bug Something's not working priority-high High priority labels Jun 7, 2024
@joemull joemull added this to the v1.5.6 milestone Jun 7, 2024
joemull added a commit that referenced this issue Jun 7, 2024
@joemull
Re-indent untyped galleys migration #4262
5b687ba
@joemull joemull self-assigned this Jun 7, 2024
@joemull joemull linked a pull request Jun 10, 2024 that will close this issue
Fix a bug that kept untyped galleys migration from taking effect #4262 #4263
Merged
ajrbyers pushed a commit that referenced this issue Jun 10, 2024
@joemull @ajrbyers
Re-indent untyped galleys migration #4262
0eff567
@joemull joemull closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joemull joemull

Labels
bug Something's not working priority-high High priority
Projects
None yet
Milestone
v1.5.6
Development

Successfully merging a pull request may close this issue.

Fix a bug that kept untyped galleys migration from taking effect #4262 openlibhums/janeway
1 participant
@joemull