Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit run time limits for the datalog engine #53

Closed
Geal opened this issue Dec 14, 2020 · 3 comments
Closed

explicit run time limits for the datalog engine #53

Geal opened this issue Dec 14, 2020 · 3 comments

Comments

@Geal
Copy link
Contributor

Geal commented Dec 14, 2020

right now, we put some hardcoded limits on the number of iterations in a "world run", but it should be better to leave that decision to the user. We can get a token with some degenerate cases that would produce a lot of facts or apply on a large number of iterations, so there should be a hard limit there.

A few options:

  • limit on the number of facts produced
  • limit on the execution time
  • if we want a safer way, optionally forbid facts and rules in blocks other than authority (so those blocks would only contain caveats)
@Geal Geal mentioned this issue Dec 18, 2020
17 tasks
@Geal
Copy link
Contributor Author

Geal commented Dec 21, 2020

implemented in the Rust version: biscuit-auth/biscuit-rust@afa0042
@daeMOn63 @titanous do you have such options for the Go version?

@Geal
Copy link
Contributor Author

Geal commented Dec 21, 2020

Java version: CleverCloud/biscuit-java@ff9c2f6

@daeMOn63
Copy link

daeMOn63 commented Jan 12, 2021

Implemented in Go version: biscuit-auth/biscuit-go@1f63389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants