Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Github Not Fully Highlighting Diff #23

Closed
Francewhoa opened this issue Dec 24, 2017 · 4 comments
Closed

Github Not Fully Highlighting Diff #23

Francewhoa opened this issue Dec 24, 2017 · 4 comments

Comments

@Francewhoa
Copy link
Member

Francewhoa commented Dec 24, 2017

Steps to reproduce

  1. Using the github interface, fork this repository https://github.com/bisq-network/docs
  2. Also fork this parent repository https://github.com/bisq-network
  3. Using the first fork above /bisq-network/docs, edit this phase-zero.adoc file
    1. Under "Introduction" section, remove 3 characters, any
  4. Still using github interface, send a pull request
    1. During your pull request, on the “Comparing changes” page, notice that the diff is not fully highlighted. This is the challenge. Find screenshot below to clarify the location of this challenge. It's the first time I saw that "glitch" with github.
  5. The expected result is that the diff is fully highlighted like in this test with another file. The fully highlighted diff allows to quickly and easily tell what is the suggested edit and its exact location. That's the whole point of a diff, LOL ;) Otherwise it's time consuming to read the whole paragraph and manually try to locate the edit.
  6. I was able to reproduce this challenge only when using this forked phase-zero.adoc file. I was not able to reproduce this challenge with any other files within the same forked repository.

Screenshot challenge

screenshot challenge---wn

Notes

@Francewhoa
Copy link
Member Author

Today I reported this challenge to github. Waiting their reply. I'll post it here if any.

@Francewhoa
Copy link
Member Author

Reply from Rachel, GitHub staff

Hey Francois,

Steps to reproduce at #23 (comment)

Thanks for writing in! It looks like you've run up against a limitation we put in place to keep our site performance up. We currently stop running word diffs on single lines that go past 512 characters, and that line seems to be over that. I'll definitely add your +1 for bumping that limit up though! Let me know if there's anything else I can help with in the meantime.

All the best,
Rachel
GitHub Support

@cbeams cbeams reopened this Dec 25, 2017
@cbeams
Copy link
Member

cbeams commented Dec 25, 2017

Thanks @Francewhoa, for solving the mystery!

Really hope GitHub does increase that 512 char limit, because that is effectively limiting writers to 512 char paragraphs—for those who subscribe to the one-line-per-paragraph approach as we do.

@cbeams cbeams closed this as completed Dec 25, 2017
@Francewhoa
Copy link
Member Author

Francewhoa commented Dec 25, 2017

@cbeams :) Yeah that limit is a party crasher for doc contributors. It also makes it harder for maintainers to review for approval pull request :( As you know documentation paragraphs often need to go over that limit. Simply because they are text visible to end-users, not line of codes, or in-line code comments visible to back-end software engineers. Also doc contributors need that full length for easy and quick automated doc spell checks, frequents updates. Plus a pleasant end-user experience when they read the doc on devices with different screen sizes with automated line brakes.

Until that limit is removed, for my future pull requests, I'm happy to try to use the pull request comment field to try to manually clarify what the propose pull request is about. I mean using this pull request as an example, which one of the following two options is easier for you when you review future doc pull requests?

Option 1: Diff location

There is a minor typo with the "to" word. The propose update is located into this sentence:

"This document is written to provide a clear..."

Option 2: Manual diff

There is a minor typo with the "to" word. I propose this:

Before
"This document is written to to provide a clear..."

After
"This document is written to provide a clear..."

Option 3: What else?

Do you have any other proposal to resolve this limit party-crasher challenge?

Option 1 is easier for me. How about u? Option 2 might be challenging if there are multiple propose edits within the same sentence.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants