Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Fixed a minor typo #22

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Fixed a minor typo #22

merged 1 commit into from
Dec 23, 2017

Conversation

Francewhoa
Copy link
Member

Title is self-explained. This is my first commit to Bisq project
on GitHub. All are welcome to let me know if any question or concern :)

This "phase-zero.adoc" document is well written, organized,
even visuals wow :) This doc is very useful to me as newcomer
to get started with the Bisq project.

@cbeams cbeams merged commit 9b4d5de into bisq-network:master Dec 23, 2017
cbeams added a commit that referenced this pull request Dec 23, 2017
@cbeams
Copy link
Member

cbeams commented Dec 23, 2017

Thanks, @Francewhoa. Also, you might be interested in this tweet: https://twitter.com/cbeams/status/944162513482145792

@Francewhoa
Copy link
Member Author

Francewhoa commented Dec 24, 2017

https://twitter.com/cbeams/status/944162513482145792

@cbeams :) Thanks for flagging that challenge. That is Scooby-Doo-weird, LOL (joke ;) Maybe a glitch with github? I actually noticed that during my pull request when reviewing the “Comparing changes”. The diff was not fully highlighted. It's the first time I saw that "glitch" with github. I mean usually the expected result is that the diff is fully highlighted like in this test I did I did today. This allows to quickly and easily tell what is the suggested edit and its exact location. That's the whole point of a diff, LOL ;) Otherwise it's time consuming to read the whole paragraph and manually try to locate the edit.

To narrow down the source of this challenge, today I did a few tests. I was able to reproduce this challenge three times. But only using this forked "phase-zero.adoc" file. I was not able to reproduce this challenge with any other files within the same fork repository.

Anyhow your merge with master was successful. How about keeping this ticket for easy reference in case this challenge happens again in the future. Steps to reproduce at #23. But for now assume it's a one time glitch with github file. Another option to consider is we could call Scooby-Doo and his pals asking them to investigate, LOL ;)
scooby doo git

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants