Fix for #2106 #3040
Merged
Fix for #2106 #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Transaction Fee - Maker Fee - Buyer Deposit - Seller Deposit
Closed
|
Formatting is wrong, best to use Looks like columns are added to UI, wouldn't it be better to not add them if they're not to be shown. |
Formatting of code? I'm working on it. The columns in the UI were added to conform with the previous code which uses the instances of the displayed columns to generate the exported CSV. |
freimair
suggested changes
Aug 6, 2019
desktop/src/main/java/bisq/desktop/main/portfolio/closedtrades/ClosedTradesView.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Columns added to export but hidden from view table.
Fixes #2106