Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2106 #3040

Merged
merged 4 commits into from Aug 9, 2019

Conversation

@niyid
Copy link
Contributor

commented Jul 31, 2019

Columns added to export but hidden from view table.

  • Transaction Fee
  • Maker Fee
  • Buyer Deposit
  • Seller Deposit

Fixes #2106

 - Transaction Fee
 - Maker Fee
 - Buyer Deposit
 - Seller Deposit
@niyid niyid requested review from ripcurlx and sqrrm as code owners Jul 31, 2019
@niyid niyid referenced this pull request Jul 31, 2019
@sqrrm

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

Formatting is wrong, best to use .editorconfig

Looks like columns are added to UI, wouldn't it be better to not add them if they're not to be shown.

@niyid

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

Formatting is wrong, best to use .editorconfig

Looks like columns are added to UI, wouldn't it be better to not add them if they're not to be shown.

Formatting of code? I'm working on it.

The columns in the UI were added to conform with the previous code which uses the instances of the displayed columns to generate the exported CSV.

niyid added 2 commits Aug 1, 2019
Copy link
Member

left a comment

NullPointerEx due to error in indexing. See the comment.

Copy link
Member

left a comment

Ack

@freimair freimair referenced this pull request Aug 9, 2019
@sqrrm sqrrm merged commit b92b4be into bisq-network:master Aug 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.