Issue #3231 Fix #3316
Closed
Issue #3231 Fix #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiz
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
Could you please fix the following:
- Swap the title and description of this PR, so that the title is "Fixes sorting in views with TableView instances with no implemented sort" and the description is "fixes Table view columns should use a numeric-sort algorithm #3231"
- Squash the 3 commits into a single commit
- The PR branch should not be named "master" but instead something like "fix-table-sort" to identify what it does
|
OK. I will get to it.
…On Fri, Sep 27, 2019, 15:14 wiz ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Could you please fix the following:
- Swap the title and description of this PR, so that the title is
"Fixes sorting in views with TableView instances with no implemented sort"
and the description is "fixes #3231
<#3231>"
- Squash the 3 commits into a single commit
- The PR branch should not be named "master" but instead something
like "fix-table-sort" to identify what it does
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3316?email_source=notifications&email_token=AE2MWR7OQOTOGQE4X6D4W2TQLYINVA5CNFSM4IZXC2V2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGFXWFI#pullrequestreview-294353685>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE2MWRZOLP67YMMTNK3RTF3QLYINVANCNFSM4IZXC2VQ>
.
|
|
closed as duplicate of #3319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sorting in views with TableView instances with no implemented sort.