Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect display of delete button next to open proposals #3920

Merged
merged 1 commit into from Jan 29, 2020
Merged

Fixes incorrect display of delete button next to open proposals #3920

merged 1 commit into from Jan 29, 2020

Conversation

niyid
Copy link
Contributor

@niyid niyid commented Jan 27, 2020

Fixes #3899 - issue not yet reproduced but structured code to prevent occurrence of issue.

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

@niyid niyid requested a review from sqrrm January 27, 2020 18:15
@ripcurlx
Copy link
Contributor

@niyid I've added a # to your bug reference so it is referenced properly and closed automatically. Also please remove info text from your PR next time. Thanks!

@ripcurlx
Copy link
Contributor

Also please use the PR title as it would be a line in the release notes (Point out the user value) and add descriptive parts into the PR description.

@ripcurlx ripcurlx changed the title #3899 fix - issue not yet reproduced but structured code to prevent occurrence of issue Fixes incorrect display of delete button next to open proposals Jan 29, 2020
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

As the change is based on my #3899 (comment) on this issue.

@ripcurlx ripcurlx merged commit f220273 into bisq-network:master Jan 29, 2020
@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 30, 2020
@ripcurlx ripcurlx added the a:bug label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAO governance open proposals show delete icon on wrong items
2 participants