Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes incorrect display of delete button next to open proposals #3920

Merged
merged 1 commit into from Jan 29, 2020

Conversation

@niyid
Copy link
Contributor

niyid commented Jan 27, 2020

Fixes #3899 - issue not yet reproduced but structured code to prevent occurrence of issue.

Fixes #replaceWithIssueNr, fixes #replaceWithIssueNr

Your PR description here.

prevent occurrence of issue.
@niyid niyid requested a review from sqrrm Jan 27, 2020
@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 29, 2020

@niyid I've added a # to your bug reference so it is referenced properly and closed automatically. Also please remove info text from your PR next time. Thanks!

@ripcurlx

This comment has been minimized.

Copy link
Member

ripcurlx commented Jan 29, 2020

Also please use the PR title as it would be a line in the release notes (Point out the user value) and add descriptive parts into the PR description.

@ripcurlx ripcurlx changed the title #3899 fix - issue not yet reproduced but structured code to prevent occurrence of issue Fixes incorrect display of delete button next to open proposals Jan 29, 2020
Copy link
Member

ripcurlx left a comment

utACK

As the change is based on my #3899 (comment) on this issue.

@ripcurlx ripcurlx merged commit f220273 into bisq-network:master Jan 29, 2020
2 checks passed
2 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ripcurlx ripcurlx added this to the v1.2.6 milestone Jan 30, 2020
@ripcurlx ripcurlx added the a:bug label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.