Dump delayed tx #3925
Merged
Dump delayed tx #3925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a separate file, delayed_payout_txs, to write all txs and their delayed payout tx hashes as json. This will enable users to publish locked txs when their data dir has been corrupted, as long as the trade data is there.
ripcurlx
approved these changes
Feb 3, 2020
There was a problem hiding this comment.
ACK
Tested on Regtest and got
[
{
"tradeId": "09129192-ecda2d7e-36d6-4a3b-b875-05579b949504-123",
"delayedPayoutTx": "01000000011db2d865d7ab4dc0de3cb0dc3f1a02738a69c401f86e68d0ecec08bc58611e7500000000d9004730440220175123ac7f010403036a5d5ef82ae976c9d32dbfe4996c83f869911796dfc1cb022041459fc5595366cdc925d0c669ebebb33f49038a95e6e0ef5d15abd22bdeb5000147304402203377ae1671ed1a5adfc73dff46033baaa71dc5c198075c17646cdf9b20bef4dd0220553c92ea2529ed06c123b636cc0890817010d538dcf3e8a6ab6e1d1156dce2b001475221033498e43bca79880e30e3ee7a3bfaea21d1f1a7a85479a9e38da72763654ad66d2103ab14b9ac8e39d3a55e66ae2e3a33a9bce1d690d3d706a4c21284619db0f789f352aefeffffff01e079af000000000017a9144c0e4893237f85479f489b32c8ff0faf3ee2e1c987ee000000"
}
]
in delayed_payout_txs.json for my trade.
ripcurlx
added
in:trade-process
is:priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently investigating an issue from a user where the trades have been corrupted and they're not able to open arbitration.
As a way to recover funds it's still possible to publish the delayed payout tx manually as long as that data is available. This PR adds a config option to dump delayed payout tx hashes to file.