Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 10 #488

Closed
sqrrm opened this issue Feb 10, 2020 · 7 comments
Closed

For Cycle 10 #488

sqrrm opened this issue Feb 10, 2020 · 7 comments
Assignees
Labels
was:accepted Indicates that a compensation request was accepted by DAO voting
Milestone

Comments

@sqrrm
Copy link
Member

sqrrm commented Feb 10, 2020

Summary

Contributions delivered

Merged Code

Stalled Trades - 900

Work on Issue with trades stalling, perhaps due to lost mailbox message. There is now a way to refresh the trade process at the step where it was failing the most.
bisq-network/bisq#3922
bisq-network/bisq#3905

Handle Payout From Corrupted Data Dirs - 360

bisq-network/bisq#3925

Work On Failed Signing - 600

There has been a lot of reports of accounts not getting signed as they should. This PR is a help in finding why accounts aren't getting signed. Included here is also support given to traders in the process of figuring out how to solve this.
bisq-network/bisq#3948

Reviews

Smaller PRs That Didn't Take Much Effort - 0

bisq-network/bisq-explorer#25
bisq-network/bisq#3881
bisq-network/bisq#3921
bisq-network/bisq#3938
bisq-network/bisq#3939
bisq-network/bisq#3799

Testing of BTC Node Validation - 250

bisq-network/bisq#3895

Config and Options Refactoring - 830

This was a monster of a change.
bisq-network/bisq#3886
bisq-network/bisq#3887
bisq-network/bisq#3888
bisq-network/bisq#3889

Remove Deposit txid From Tradestats - 300

This is a quite sensitive change and needed a fair bit of testing. Even with this testing I think it wasn't enough and we'll have to revert this change partially to do it more thoroughly.
bisq-network/bisq#3911
bisq-network/bisq#3933

Support

Smaller Cases - 600

Didn't log every case in detail early on this cycle.

Failed Mediation Payout - 240

Trade failed at mediation payout as trader clicked accept but nothing happened. Never heard back from other trader. Managed to create error exception in regtest. Now documented in bisq-network/bisq#3915. This should be reasonably easily fixed.

Mediator UI Issue - 260

Bug: mediators unable to get the right payout done due to balances not calculated correctly. Can now reproduce, see bisq-network/bisq#3906. A workaround was found to handle this.

Failed Bitcoinj Sync - 100

User was couldn't start Bisq, failed on IllegalStateException. After some investigation it was solved by manually deleting DATADIR/btc_mainnet/wallet/bisq.spvchain as it wasn't possible to do it through the app since it didn't start.

Contributions in progress

Roles performed

Total for roles - 450

Bitcoin node maintainer - bisq-network/roles#66 (comment) 75
Bitcoin node operator - bisq-network/roles#67 (comment) 150
Tor relay operator - bisq-network/roles#72 (comment) 75
Explorer maintainer/operator - bisq-network/roles#11 (comment) 150
Bisq desktop maintainer - bisq-network/roles#63 (comment) 0

@sqrrm sqrrm changed the title [WIP] Cycle 10 Cycle 10 Feb 11, 2020
@cbeams cbeams changed the title Cycle 10 For Cycle 10 Feb 11, 2020
@cbeams cbeams moved this from In Progress to Waiting for Team Lead Review in Compensation Requests Feb 11, 2020
@wiz
Copy link
Member

wiz commented Feb 13, 2020

👍 for ops roles

@cbeams cbeams assigned wiz and unassigned sqrrm Feb 13, 2020
@ripcurlx
Copy link
Contributor

👍 for dev efforts

@ripcurlx ripcurlx moved this from In Review to Review Complete in Compensation Requests Feb 13, 2020
@wiz
Copy link
Member

wiz commented Feb 13, 2020

@sqrrm please post TXID of DAO compensation proposal

@sqrrm
Copy link
Member Author

sqrrm commented Feb 13, 2020

@wiz Will do once I make a proposal.

@MwithM
Copy link
Contributor

MwithM commented Feb 14, 2020

Proposal phase ends 15 feb 06:00 GMT, block 617.466.

@MwithM
Copy link
Contributor

MwithM commented Feb 15, 2020

Please next cycle publish tx I in a new post so I can see it faster to mark it as "proposal submitted".

Proposal TxId: 9307fa9254ded84d89e231b9c6930b04b756741d4a920e38a98251e8250cb8d6

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Requests Feb 15, 2020
@cbeams cbeams added this to Proposal Submitted in Compensation Request Board Feb 17, 2020
@MwithM MwithM added the was:accepted Indicates that a compensation request was accepted by DAO voting label Feb 22, 2020
@MwithM
Copy link
Contributor

MwithM commented Feb 22, 2020

Was accepted

@MwithM MwithM closed this as completed Feb 22, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Feb 22, 2020
@cbeams cbeams added this to the Cycle 10 milestone Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
was:accepted Indicates that a compensation request was accepted by DAO voting
Projects
Compensation Requests
  
Proposal Submitted
Development

No branches or pull requests

5 participants