Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check given $id for being a non-empty string #61

Closed
dropdevcoding opened this issue Sep 29, 2016 · 1 comment
Closed

Check given $id for being a non-empty string #61

dropdevcoding opened this issue Sep 29, 2016 · 1 comment
Labels
enhancement
Milestone
0.6.0

Comments

@dropdevcoding
Copy link
Contributor

Since the Container-Interop ContainerInterface does not use type hinting but the get() and has() method have declared $id as string param type, AnnotationBeanFactory should check the given id for being a non-empty string and throw an exception else. Otherwise at least the AliasContainer will throw a confusing exception concerning the AliasContainer because hasAlias has defined a string type hint in its signature.
@shochdoerfer
Copy link
Member

Mind preparing a PR?

dropdevcoding added a commit to dropdevcoding/disco that referenced this issue Sep 30, 2016
@dropdevcoding
Implements bitExpert#61
e03ff34
@dropdevcoding dropdevcoding mentioned this issue Sep 30, 2016
Merged
shochdoerfer added a commit that referenced this issue Oct 3, 2016
@shochdoerfer
Merge pull request #62 from dropdevcoding/feature/id_check
a7cf247 
Implements #61
@shochdoerfer shochdoerfer added this to the 0.6.0 milestone Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@shochdoerfer @dropdevcoding