Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run benchmarks on CI, test for regressions #1

Closed
bitjson opened this issue May 28, 2018 · 1 comment
Closed

Run benchmarks on CI, test for regressions #1

bitjson opened this issue May 28, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@bitjson
Copy link
Member

bitjson commented May 28, 2018

Currently benchmarks can be manually run with yarn bench. It would be great if this was part of CI builds and tested for notable regressions from previous results.
@bitjson bitjson added the help wanted Extra attention is needed label Jul 8, 2018
@bitjson
Copy link
Member Author

bitjson commented Jul 8, 2018

Running benchmarks on CI as of bitjson@2910e19

It would be better to somehow automatically check for big regressions (by comparing results with previous CI builds), but I don't think that's worth working on/maintaining yet. For now, we can manually review the benchmarks for regression when pulling in changes that touch benchmarked functionality.

(If anyone wants to pick this up in the future, I'd love to see it happen.)

@bitjson bitjson closed this as completed Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bitjson