Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons are added to Graph Hbox, not outside it #257

Merged

Conversation

bits-by-brandon
Copy link
Contributor

Description

Edits button logic to insert Make Floating button and Toggle Panel button inside the GraphEdit HBox instead of beside it.
Allows buttons to be clicked

Note: This doesn't fix the icons for me, but at least fixes the clicking.

Addressed issues

Screenshots

Screenshot 2023-11-30 at 7 37 36 PM

@bits-by-brandon
Copy link
Contributor Author

Register singleton 'regex_richtext:<RegEx#-9223371819002624369>'

What's this testing for? Is this flake or should I fix something?

@@ -45,6 +46,7 @@ func _ready() -> void:

var toggle_button := Button.new()
toggle_button.flat = true
toggle_button.name = "TogglePanelButton"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These names are just for helpful debugging in the Remote scene view

@bits-by-brandon
Copy link
Contributor Author

Still getting this very slightly out of acceptable range error:

Run Test Suite res://test/randomized_composites/weighted_sampling/selector_random/selector_random_weights_test.gd 
	Run Test: res://test/randomized_composites/weighted_sampling/selector_random/selector_random_weights_test.gd > test_weights_effecting_sample :STARTED
Register singleton 'GdUnitDefaultValueDecoders:<RefCounted#-9223371819304614250>'
	Run Test: res://test/randomized_composites/weighted_sampling/selector_random/selector_random_weights_test.gd > test_weights_effecting_sample :FAILED 262ms
	Report:
Register singleton 'regex_richtext:<RegEx#-9223371819002624369>'
		line 36: Expecting:
		 '54.014599'
		 in range between
		 '46.000000' <> '54.000000'

@bitbrain
Copy link
Owner

bitbrain commented Dec 3, 2023

Those are flaky tests in the main branch I aim to fix today. Sorry for that!

@bitbrain
Copy link
Owner

bitbrain commented Dec 3, 2023

Screenshot 2023-12-03 102316

This is how this PR looks on my end. Good job! I will fix the icon scaling separately.

@bitbrain bitbrain merged commit ac597cb into bitbrain:godot-4.x Dec 3, 2023
4 checks passed
@bits-by-brandon bits-by-brandon deleted the debugger-control-issues branch September 7, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants