Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit()

Summary: Functions no longer used. Partial backport of Core [[bitcoin/bitcoin#13825 | PR13825]] bitcoin/bitcoin@e6fcc5d bitcoin/bitcoin@7a0d8f4 Depends on D5316 Test Plan: ninja check Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5412
bitcoin-cash-node · Apr 24, 2020 · 44edc0c · 44edc0c
1 parent 2413f55
commit 44edc0c
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 21 deletions.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -3513,12 +3513,6 @@ bool CWallet::CommitTransaction(
     return true;
 }
 
-void CWallet::ListAccountCreditDebit(const std::string &strAccount,
-                                     std::list<CAccountingEntry> &entries) {
-    WalletBatch batch(*database);
-    return batch.ListAccountCreditDebit(strAccount, entries);
-}
-
 bool CWallet::AddAccountingEntry(const CAccountingEntry &acentry) {
     WalletBatch batch(*database);
 

diff --git a/src/wallet/wallet.h b/src/wallet/wallet.h
@@ -1212,8 +1212,6 @@ class CWallet final : public CCryptoKeyStore, public CValidationInterface {
         std::string fromAccount, CReserveKey &reservekey, CConnman *connman,
         CValidationState &state);
 
-    void ListAccountCreditDebit(const std::string &strAccount,
-                                std::list<CAccountingEntry> &entries);
     bool AddAccountingEntry(const CAccountingEntry &);
     bool AddAccountingEntry(const CAccountingEntry &, WalletBatch *batch);
     bool DummySignTx(CMutableTransaction &txNew, const std::set<CTxOut> &txouts,

diff --git a/src/wallet/walletdb.cpp b/src/wallet/walletdb.cpp
@@ -190,18 +190,6 @@ bool WalletBatch::WriteAccountingEntry(const uint64_t nAccEntryNum,
         acentry);
 }
 
-Amount WalletBatch::GetAccountCreditDebit(const std::string &strAccount) {
-    std::list<CAccountingEntry> entries;
-    ListAccountCreditDebit(strAccount, entries);
-
-    Amount nCreditDebit = Amount::zero();
-    for (const CAccountingEntry &entry : entries) {
-        nCreditDebit += entry.nCreditDebit;
-    }
-
-    return nCreditDebit;
-}
-
 void WalletBatch::ListAccountCreditDebit(const std::string &strAccount,
                                          std::list<CAccountingEntry> &entries) {
     bool fAllAccounts = (strAccount == "*");

diff --git a/src/wallet/walletdb.h b/src/wallet/walletdb.h
@@ -210,7 +210,6 @@ class WalletBatch {
     /// Erase destination data tuple from wallet database.
     bool EraseDestData(const CTxDestination &address, const std::string &key);
 
-    Amount GetAccountCreditDebit(const std::string &strAccount);
     void ListAccountCreditDebit(const std::string &strAccount,
                                 std::list<CAccountingEntry> &acentries);